Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve parser handling of single-line array/object #4956

Merged
merged 2 commits into from
Oct 23, 2021
Merged

Improve parser handling of single-line array/object #4956

merged 2 commits into from
Oct 23, 2021

Conversation

anthony-c-martin
Copy link
Member

@anthony-c-martin anthony-c-martin commented Oct 22, 2021 •
edited
Loading

Closes #4955
Closes #2056

majastrz
majastrz approved these changes Oct 23, 2021
View reviewed changes
Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@anthony-c-martin anthony-c-martin merged commit d7a7438 into main Oct 23, 2021
@anthony-c-martin anthony-c-martin deleted the ant/4955 branch October 23, 2021 03:48
@alex-frankel
Copy link
Collaborator

@anthony-c-martin -- does this also fix #2056?

@anthony-c-martin anthony-c-martin mentioned this pull request Oct 25, 2021
Closed
@anthony-c-martin
Copy link
Member Author

@anthony-c-martin -- does this also fix #2056?

Looks like! I've closed it.

@alex-frankel alex-frankel mentioned this pull request Oct 26, 2021
Closed
@anthony-c-martin anthony-c-martin mentioned this pull request Nov 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majastrz majastrz majastrz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Single line array with item breaks validation Confusing error message if array missing expected newline
3 participants
@anthony-c-martin @alex-frankel @majastrz