Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set assigning an expression to a read-only property diagnostic to always be a warning #5509

Merged
merged 4 commits into from
Feb 2, 2022
Merged

Set assigning an expression to a read-only property diagnostic to always be a warning #5509

merged 4 commits into from
Feb 2, 2022

Conversation

miqm
Copy link
Collaborator

@miqm miqm commented Dec 23, 2021

Fixes Azure/bicep-types-az#2216

Contributing a feature

  • I have opened a new issue for the proposal, or commented on an existing one, and ensured that the Bicep maintainers are good with the design of the feature being implemented
  • I have included "Fixes #{issue_number}" in the PR description, so GitHub can link to the issue and close it when the PR is merged
  • I have appropriate test coverage of my new feature

@miqm miqm force-pushed the bugfix/read-only-top-level-property-5456 branch from 2cefbd8 to feb595c Compare December 30, 2021 18:21
@miqm miqm modified the milestone: v0.5 Jan 24, 2022
This was referenced Jan 25, 2022
Open
Open
majastrz
majastrz approved these changes Feb 2, 2022
View reviewed changes
Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@majastrz majastrz merged commit 097913f into Azure:main Feb 2, 2022
@alex-frankel alex-frankel mentioned this pull request Feb 2, 2022
Closed
26 tasks
@miqm miqm deleted the bugfix/read-only-top-level-property-5456 branch February 2, 2022 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majastrz majastrz majastrz approved these changes

@anthony-c-martin anthony-c-martin Awaiting requested review from anthony-c-martin

Assignees
No one assigned
Labels
None yet
Projects
Bicep
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Microsoft.Automation/automationAccounts/configurations - The property "properties" is read-only
3 participants
@miqm @majastrz @anthony-c-martin