Avoid parsing snippets with placeholders #5858
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my other branch, I was running into a huge number of
ExpectedTokenException
errors on startup, because theSnippetProvider
processes the snippets after placeholder replacement - at which point in time, the file is not a syntactically valid Bicep file. This is unnecessary, and in my branch actually resulted in invalid snippets being generated due to syntax ambiguity.Here I've modified
SnippetProvider
to do its analysis on the snippets with placeholders instead (which are validated for parse errors on checkin).To give a concrete example, previously we were trying to parse the following (note that
${
and}
are not recognized as valid Bicep syntax:Now we're trying to parse the following: