Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Anonymous module artifact fetch when encountering status 403 #6284

Merged
merged 1 commit into from
Mar 25, 2022
Merged

Anonymous module artifact fetch when encountering status 403 #6284

merged 1 commit into from
Mar 25, 2022

Conversation

slapointe
Copy link
Contributor

Fixes #6202

I added tracing for the authenticated and anonymous attempt.

Contributing a feature

  • I have opened a new issue for the proposal, or commented on an existing one, and ensured that the Bicep maintainers are good with the design of the feature being implemented
  • I have included "Fixes #{issue_number}" in the PR description, so GitHub can link to the issue and close it when the PR is merged
  • I have appropriate test coverage of my new feature

@slapointe slapointe requested a review from shenglol March 24, 2022 21:13
shenglol
shenglol approved these changes Mar 24, 2022
View reviewed changes
Copy link
Contributor

@shenglol shenglol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@slapointe slapointe force-pushed the feature/public-anonymous-registry-not-working-in-azure-pipeline-6202 branch from 38af13f to f97a6ba Compare March 25, 2022 03:13
@slapointe slapointe changed the title Anonymous module artifact fetch when encountering status 403, fixes #6202 Anonymous module artifact fetch when encountering status 403 Mar 25, 2022
@shenglol shenglol merged commit 0c42576 into Azure:main Mar 25, 2022
@Agazoth
Copy link

Agazoth commented Mar 25, 2022

Thanks, @slapointe ! I can confirm, that the new build works. You rock!

@slapointe slapointe deleted the feature/public-anonymous-registry-not-working-in-azure-pipeline-6202 branch March 25, 2022 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shenglol shenglol shenglol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Public anonymous registry not working in Azure Pipeline
3 participants
@slapointe @Agazoth @shenglol