Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid serializing and deserializing template specs #6833

Merged
merged 1 commit into from
May 12, 2022

Conversation

shenglol
Copy link
Contributor

@shenglol shenglol commented May 12, 2022

We bumped Azure.ResourceManager.Resources to 1.0.0 (#6538) to support Bicep deploy command, but it introduced some breaking changes to the template spec resource models which breaks template specs serialization. The PR updates TemplateSpecEntity to only contain the raw response content from the template get API call which removes the need for serialization.

Fixes #6823.

Microsoft Reviewers: Open in CodeFlow

@shenglol shenglol enabled auto-merge (squash) May 12, 2022 21:23
@shenglol shenglol merged commit 46dd19e into main May 12, 2022
@shenglol shenglol deleted the shenglol/fix-template-spec-serialization branch May 12, 2022 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Referencing Template Specs is broken in versions 0.6.1 and 0.6.11
3 participants