Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide better errors for comma separators #736

Merged
merged 10 commits into from
Oct 28, 2020
Merged

Conversation

TSunny007
Copy link
Contributor

Anytime a comma is hit when expecting a newline we throw a new error

@codecov-io
Copy link

codecov-io commented Oct 26, 2020

Codecov Report

Merging #736 into main will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #736   +/-   ##
=======================================
  Coverage   94.35%   94.36%           
=======================================
  Files         274      274           
  Lines       11545    11565   +20     
  Branches       12       12           
=======================================
+ Hits        10893    10913   +20     
  Misses        652      652           
Flag Coverage Δ
#dotnet 95.12% <100.00%> (+<0.01%) ⬆️
#typescript 25.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Bicep.Core/Diagnostics/DiagnosticBuilder.cs 100.00% <100.00%> (ø)
src/Bicep.Core/Parser/Parser.cs 93.68% <100.00%> (+0.25%) ⬆️

@TSunny007 TSunny007 linked an issue Oct 26, 2020 that may be closed by this pull request
Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments.

@TSunny007 TSunny007 requested a review from majastrz October 28, 2020 19:44
Copy link
Member

@anthony-c-martin anthony-c-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor nitpick comment

@TSunny007 TSunny007 merged commit 2b5b6bb into main Oct 28, 2020
@TSunny007 TSunny007 deleted the tsunkaraneni/commaseperator branch October 28, 2020 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

line terminating comma error is ambiguous/misleading
4 participants