-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide better errors for comma separators #736
Conversation
Codecov Report
@@ Coverage Diff @@
## main #736 +/- ##
=======================================
Coverage 94.35% 94.36%
=======================================
Files 274 274
Lines 11545 11565 +20
Branches 12 12
=======================================
+ Hits 10893 10913 +20
Misses 652 652
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments.
src/Bicep.Core.Samples/Files/InvalidParameters_LF/main.diagnostics.bicep
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a minor nitpick comment
Anytime a comma is hit when expecting a newline we throw a new error