Skip to content
This repository has been archived by the owner on Jul 18, 2024. It is now read-only.

Fix 144, add support for Managed Disk SAS tokens #145

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

kf6kjg
Copy link

@kf6kjg kf6kjg commented Jun 21, 2023

Pull Request Checklist

  • Review the contributing guidelines
  • Outstanding issue linked, if applicable
  • PR should only be opened against master if it includes no features (open against develop otherwise)
  • Commit messages should conform to good style practices
  • PR should pass all checks and have no conflicts

Description

Re-works the domain parsing for mode and ep to work with managed disk URLs and all existing URLs as well.

Fixes #144

Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com>
@kf6kjg
Copy link
Author

kf6kjg commented Jun 21, 2023

Hmm, CI failure looks to be caused by the CI using tox 4 or newer: the tox.inirules have changed. See https://tox.wiki/en/latest/upgrading.html

Fixing that bit of outdated config to get CI working..

@kf6kjg
Copy link
Author

kf6kjg commented Jun 21, 2023

Looks like the CI is still broken, this time because of a codecov usage problem:

/home/vsts/work/_temp/c77f6f39-378b-4090-ac61-942334cc01a5.sh: line 4: codecov.uploadToken: command not found
usage: codecov [-h] [--version] [--token TOKEN] [--file [FILE [FILE ...]]]
               [--flags [FLAGS [FLAGS ...]]] [--env [ENV [ENV ...]]]
               [--required] [--name NAME] [--gcov-root GCOV_ROOT]
               [--gcov-glob [GCOV_GLOB [GCOV_GLOB ...]]]
               [--gcov-exec GCOV_EXEC] [--no-gcov-out] [--gcov-args GCOV_ARGS]
               [-X [DISABLE [DISABLE ...]]] [--root ROOT] [--commit COMMIT]
               [--prefix PREFIX] [--branch BRANCH] [--build BUILD] [--pr PR]
               [--tag TAG] [--tries TRIES] [--slug SLUG] [--url URL]
               [--cacert CACERT] [--dump] [-v] [--no-color]
codecov: error: argument --token/-t: expected one argument

I'll leave the fixing of that one up to the repo maintainers, I've used as much time on this today as I can afford. I recommend that the maintainers pin the versions of the tools they are using in their CI.

@kf6kjg kf6kjg marked this pull request as ready for review June 21, 2023 17:46
@kf6kjg kf6kjg changed the title Fix 144 Fix 144, add support for Managed Disk SAS tokens Jun 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant