Fix mounting file into image source #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old behavior was odd in this case where it could mount the file into a subdirectory of the path we requested (not desirable) and it was named after the parent source. E.g. if you have an image source "foo" and you specify a file-based source at mount point '/some_file', it would mount this file as "/some_file/foo". Signed-off-by: Brian Goff <cpuguy83@gmail.com>
cpuguy83
force-pushed
the
fix_file_source_mount
branch
from
a17521d
to
03641b3
Compare
adamperlin
reviewed
Apr 10, 2024
| @@ -195,7 +195,7 @@ func generateSourceFromImage(name string, st llb.State, cmd *Command, sOpts Sour | |||
| baseRunOpts := []llb.RunOption{CacheDirsToRunOpt(cmd.CacheDirs, "", "")} | |||
|
|
|||
| for _, src := range cmd.Mounts { | |||
| srcSt, err := src.Spec.AsMount(name, sOpts, opts...) | |||
There was a problem hiding this comment.
I think this may have been a mistake from the refactor
There was a problem hiding this comment.
🤷 It happens, now we have a test case for it 😆
adamperlin
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old behavior was odd in this case where it could mount the file into a subdirectory of the path we requested (not desirable) and it was named after the parent source.
E.g. if you have an image source "foo" and you specify a file-based source at mount point '/some_file', it would mount this file as "/some_file/foo".
Related to the comment in this gist: https://gist.github.com/cpuguy83/c570f3ea97af215af63264061cac94af#file-spec-yaml-L114