Add support for azlinux3 #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpuguy83
changed the title
cpuguy83
force-pushed
the
azlinux3
branch
3 times, most recently
from
243641f
to
e0dda1b
Compare
cpuguy83
force-pushed
the
azlinux3
branch
2 times, most recently
from
1ba981a
to
89cfcf4
Compare
sozercan
reviewed
May 10, 2024
This moves some things around to make the mariner2 implementation re-usable for azlinux3.
This changes some things in the mariner2 target so we can share as much as makes sense for azlinux3. Note: mariner was renamed to azure linux, hence mariner2 -> azlinux3. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
This requires callers to pass in a default image config instead of expecting the function to resolve a config from an image ref. This makes things a bit easier to integrate with and not making assumptions that the base config is going to come from an image ref. In the future I plan to make the default base config to by built-in rather than always pulling from an image ref. This will save a round trip with the registry and makes ure we aren't relying on an image in the registry that we wouldn't otherwise need to. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the changes here is shuffling bits around to allow shared implementations between mariner2 and azlinux3.
Also includes some simplifications around creating an image config.
Closes #210