Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for the go module generator. #224

Merged
merged 1 commit into from
May 1, 2024

Conversation

cpuguy83
Copy link
Member

No description provided.

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
@cpuguy83 cpuguy83 requested a review from a team as a code owner April 30, 2024 23:07
@cpuguy83 cpuguy83 enabled auto-merge (rebase) May 1, 2024 17:14
@cpuguy83 cpuguy83 added this to the v0.3.0 milestone May 1, 2024

Adding a gomod generator to 1 or more sources causes the following to occur automatically:

1. Fetch all go module dependencies for *all* sources in the spec that specifiy the generator
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Fetch all go module dependencies for *all* sources in the spec that specifiy the generator
1. Fetch all go module dependencies for *all* sources in the spec that specify the generator

Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor typo, otherwise lgtm

@cpuguy83 cpuguy83 merged commit f80b5a9 into Azure:main May 1, 2024
5 checks passed
@cpuguy83
Copy link
Member Author

cpuguy83 commented May 1, 2024

Ooop, I had it on automerge on approval.
Let me open a PR to fix.

@cpuguy83 cpuguy83 deleted the add_gomod_docs branch May 1, 2024 21:08
@cpuguy83 cpuguy83 mentioned this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants