Add support to spec for config files from sources #247
Conversation
Signed-off-by: Jeremy Rickard <jrickard@microsoft.com>
spec.go
Outdated
| @@ -129,7 +129,9 @@ type Artifacts struct { | |||
| Manpages map[string]ArtifactConfig `yaml:"manpages,omitempty" json:"manpages,omitempty"` | |||
| // Directories is a list of various directories that should be created by the RPM. | |||
| Directories *CreateArtifactDirectories `yaml:"createDirectories,omitempty" json:"createDirectories,omitempty"` | |||
| // TODO: other types of artifacts (systtemd units, libexec, configs, etc) | |||
| // ConfigFiles is a list of files that should be marked as config files in the RPM. | |||
There was a problem hiding this comment.
Missed the in the RPM part in the last PR.
Should be in the package
There was a problem hiding this comment.
doh updated this and the directories string.
spec.go
Outdated
| // This is used to customize the settings for a config entry in the resulting artifact. | ||
| type ArtifactConfigFileConfig struct { | ||
| ArtifactConfig | ||
| ReplaceOnUpdate bool `yaml:"replace,omitempty" json:"replace,omitempty"` |
There was a problem hiding this comment.
Can you add a doc string for this?
There was a problem hiding this comment.
Actually reading up on %config(noreplace), I think we should just assume this and use a normal ArtifactConfig.
If we need to tweak in the future we can add an option but I'm thinking %config(noreplace) is the normal correct behavior.
There was a problem hiding this comment.
sounds good to me, made this change.
spec.go
Outdated
| // ArtifactConfigFileConfig is the configuration give for Artifact Config Files. | ||
| // This is used to customize the settings for a config entry in the resulting artifact. | ||
| type ArtifactConfigFileConfig struct { | ||
| ArtifactConfig |
There was a problem hiding this comment.
| ArtifactConfig | |
| ArtifactConfig `yaml:",inline"` |
There was a problem hiding this comment.
I've removed this entire struct now in favor of just Artifactconfig.
Signed-off-by: Jeremy Rickard <jrickard@microsoft.com>
What this PR does / why we need it:
This PR adds the ability to define config files for the resulting artifact and the relevant %config entries in the %files section, It also supports the optional inclusion of the %config(noreplace) with a boolean in the config.
This also updates the spec to add this (and directories) to the IsEmpty method for the Artifact.
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #246
Special notes for your reviewer: