Add support for passing build args to signers #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmengelbert
requested changes
Jun 3, 2024
There was a problem hiding this comment.
This looks good. Just to make sure I understand how dalec will behave after this PR is merged, is the following accurate?
- Values needed for the signing image can be provided via the
package_configsection, either on the spec level, or on the level of a specific target. (good for packages with both linux + windows targets). - These values can be supplied at build-invocation time by leveraging the spec's
args. - The args will be read by the consumer (i.e. the signing image) via the filesystem, and will have to be initialized into the environment on that end.
The only actionable request I have is that this should be captured in an example somewhere (in the docs/examples directory perhaps). As we keep adding features like this, having an up-to-date example with the kitchen sink makes it easier for all the developers on the project to track spec and feature changes.
|
Updated with doc updates. |
|
I think this needs to be rebased, then it should pass the CI |
pmengelbert
reviewed
Jun 7, 2024
I considered extending this to allow this for any kind of frontend (and as such sticking it into the `dalec.Frontend` type), however there really shouldn't be different vars passed to target frontends. Hence why I am restricting this to just signers for now. If we decide to later we can add this more generically, however it will be much more difficult to take it away if we decide it was a bad idea. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
|
This was rebased, FYI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I considered extending this to allow this for any kind of frontend (and as such sticking it into the
dalec.Frontendtype), however there really shouldn't be different vars passed to target frontends. Hence why I am restricting this to just signers for now.If we decide to later we can add this more generically, however it will be much more difficult to take it away if we decide it was a bad idea.
Related to #263