Fix cmd mounts #300
Merged
Fix cmd mounts #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an edge case where the source is an image which we run a command(s) in but are not extracting a subpath out. Such a case is probably a mistake and I plan to make another PR which introduces support for sending warnings back to the client but in any case before this change it is completely broken and gives a cryptic error due to trying to run a container against an empty filesystem. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
to extract This is a case that doesn't really make sense is is almost certainly user error, so make a friendly message for it. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
adamperlin
reviewed
Jun 26, 2024
adamperlin
requested changes
Jun 26, 2024
adamperlin
reviewed
Jun 27, 2024
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
adamperlin
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds additional validations to sources to prevent hitting cryptic errors, or worse unexpected data in a specified source.