source: context: Optimize fetch by path #352
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpuguy83
force-pushed
the
optimize_context
branch
from
6950f9b
to
117dbc4
Compare
adamperlin
reviewed
Aug 22, 2024
cpuguy83
force-pushed
the
optimize_context
branch
from
117dbc4
to
2243dba
Compare
This makes sure that if a path is specified on a context source that we we only ever fetch the content from beneath that path. Before this change we were doing the context path filtering after the content was fetched. This also makes so that include/exclude patterns are automatically namespaced by the source path, since it doesn't make sense to include files that are outside of the source path. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
cpuguy83
force-pushed
the
optimize_context
branch
from
2243dba
to
ec31600
Compare
|
@adamperlin updated this with a much cleaner implementation now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure that if a path is specified on a context source that we we only ever fetch the content from beneath that path.
Before this change we were doing the context path filtering after the content was fetched.
This also makes so that include/exclude patterns are automatically namespaced by the source path, since it doesn't make sense to include files that are outside of the source path.