WIP: Spec out extra repo support #365
Conversation
|
I think we should probably make this available from a separate file like we do with the signing spec so that we don't have to repeat the same thing in every single spec. Also thinking of a slight change here: Instead of splitting up repo configs between build/install just add respective fields (or a string array with validated values) that includes which environments they need to go into. This may also help reduce duplication. |
| Keys []Source `yaml:"keys,omitempty" json:"keys,omitempty"` | ||
| // Config list of repo configs to to add to the environment. The format of | ||
| // these configs is going to be distro specific (e.g. apt/yum configs). | ||
| Config []Source `yaml:"config" json:"config"` |
There was a problem hiding this comment.
Is it likely for one repository "unit" to need multiple config files? Just trying to understand why we need an array here
There was a problem hiding this comment.
Mainly that I don't want to box in what can be done.
It also allows multiple repos to be installed at the same time using the same keys.
There was a problem hiding this comment.
Got it, that makes sense!
cpuguy83
force-pushed
the
extra_repos
branch
from
32556af
to
4860505
Compare
|
Pushed a pretty significant change to what was already there. |
| // As an example, if the provided config is referencing a file backed repository | ||
| // then data would include the file data, assuming its not already available | ||
| // in the environment. | ||
| Data []SourceMount `yaml:"data,omitempty" json:"data,omitempty"` |
There was a problem hiding this comment.
Figured we could add this so that we can get rid of the extra step of adding a repo to the worker image in the tests.
|
#366 is where the work to implement this is happening. |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: