Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding AML Policy to Disable Public Network Access #175

Merged
merged 1 commit into from
Sep 16, 2021
Merged

Adding AML Policy to Disable Public Network Access #175

merged 1 commit into from
Sep 16, 2021

Conversation

marvinbuss
Copy link
Collaborator

This PR fixes

  • Added missing policy to disable public network access for Azure Machine Learning workspaces. This policy is not existing as built-in today and is therefore included here for reference.

@marvinbuss marvinbuss added the enhancement New feature or request label Sep 15, 2021
@marvinbuss marvinbuss self-assigned this Sep 15, 2021
@marvinbuss marvinbuss requested a review from a team as a code owner September 15, 2021 15:03
marvinbuss
marvinbuss commented Sep 15, 2021
View reviewed changes
Copy link
Collaborator Author

@marvinbuss marvinbuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marvinbuss
Copy link
Collaborator Author

Deployment works as expected and effects are also working as shown here:
image

@amanjeetsingh
Copy link
Contributor

Did a visual check; compared it to the policies we already have in place; looks ok to me.
Approving PR.

amanjeetsingh
amanjeetsingh approved these changes Sep 16, 2021
View reviewed changes
Copy link
Contributor

@amanjeetsingh amanjeetsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a visual check; compared the policy definitions which already work.
Approving changes. Thanks!

@amanjeetsingh amanjeetsingh merged commit d81918a into main Sep 16, 2021
@amanjeetsingh amanjeetsingh deleted the feature/aml_policy_publicnetworkaccess branch September 16, 2021 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amanjeetsingh amanjeetsingh amanjeetsingh approved these changes

@esbran esbran Awaiting requested review from esbran

@sasever sasever Awaiting requested review from sasever

Assignees

@marvinbuss marvinbuss

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marvinbuss @amanjeetsingh