Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Guidance for Self-Hosted Agents #192

Merged
merged 15 commits into from
Oct 25, 2021
Merged

Added Guidance for Self-Hosted Agents #192

merged 15 commits into from
Oct 25, 2021

Conversation

marvinbuss
Copy link
Collaborator

This PR fixes
This PR will add guidance around how to deploy through CI/CD using self-hosted Agents in ESA. It includes:

  • Guidance
  • ARM/Bicep template for DevOps Self-hosted Agents
  • Portal UI

@marvinbuss marvinbuss added documentation Improvements or additions to documentation enhancement New feature or request labels Oct 13, 2021
@marvinbuss marvinbuss self-assigned this Oct 13, 2021
@marvinbuss
Copy link
Collaborator Author

marvinbuss commented Oct 13, 2021 •
edited
Loading

TODO:

  • Portal Frontend
  • Doc

@marvinbuss
updated docs
0b88848
@marvinbuss
Added docs
e4a34ba
@marvinbuss
* updated docs
3696036 
* added portal
* added images
* updated portal def to fix typos
@marvinbuss
linting
18e238a
@marvinbuss
Copy link
Collaborator Author

Preview Link

@marvinbuss
Copy link
Collaborator Author

Deployment and ADO connection works fine:
image

marvinbuss
marvinbuss commented Oct 15, 2021
View reviewed changes
Copy link
Collaborator Author

@marvinbuss marvinbuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marvinbuss marvinbuss linked an issue Oct 15, 2021 that may be closed by this pull request
Add Guidance for hosting Self-Hosted Agents in ESA #195
Closed
@marvinbuss marvinbuss added this to the v1.2.0 milestone Oct 18, 2021
@marvinbuss marvinbuss marked this pull request as ready for review October 18, 2021 10:17
@marvinbuss marvinbuss requested a review from a team as a code owner October 18, 2021 10:17
@marvinbuss marvinbuss added the committed Committed item label Oct 19, 2021
amanjeetsingh
amanjeetsingh approved these changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@amanjeetsingh amanjeetsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

marvinbuss
marvinbuss commented Oct 25, 2021
View reviewed changes
Copy link
Collaborator Author

@marvinbuss marvinbuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marvinbuss marvinbuss merged commit cfe6985 into main Oct 25, 2021
@marvinbuss marvinbuss deleted the test branch October 25, 2021 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amanjeetsingh amanjeetsingh amanjeetsingh approved these changes

@andrehass andrehass Awaiting requested review from andrehass

Assignees

@marvinbuss marvinbuss

Labels
committed Committed item documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.

Add Guidance for hosting Self-Hosted Agents in ESA
2 participants
@marvinbuss @amanjeetsingh