Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ESA Deployment Bug #230

Merged
merged 2 commits into from
Nov 12, 2021
Merged

Fix ESA Deployment Bug #230

merged 2 commits into from
Nov 12, 2021

Conversation

marvinbuss
Copy link
Collaborator

This PR fixes
This PR will fix the bug reported by @devlace. One of the parameters was defined at the wrong location, which will be fixed with this.

@marvinbuss marvinbuss added bug Something isn't working committed Committed item labels Nov 11, 2021
@marvinbuss marvinbuss added this to the v1.2.0 milestone Nov 11, 2021
@marvinbuss marvinbuss self-assigned this Nov 11, 2021
@marvinbuss marvinbuss requested a review from a team as a code owner November 11, 2021 09:42
@marvinbuss marvinbuss linked an issue Nov 11, 2021 that may be closed by this pull request
Copy link
Collaborator Author

@marvinbuss marvinbuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marvinbuss
Copy link
Collaborator Author

Preview Link

Copy link
Contributor

@amanjeetsingh amanjeetsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

@marvinbuss marvinbuss merged commit 6aa400c into main Nov 12, 2021
@marvinbuss marvinbuss deleted the marvinbuss/params_bug branch November 12, 2021 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working committed Committed item
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when trying to deploy
2 participants