Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Docs for consistency #235

Merged
merged 2 commits into from
Nov 22, 2021
Merged

Updated Docs for consistency #235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7487518
Updated Docs for consistency
marvinbuss Nov 17, 2021
69fd90d
Merge branch 'main' into marvinbuss/concistency_updates
marvinbuss Nov 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/EnterpriseScaleAnalytics-AzureDevOpsDeployment.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ To begin, please open the [infra/params.dev.json](/infra/params.dev.json). In th
| `environment` | Specifies the environment of the deployment. | `dev`, `tst` or `prd` |
| `prefix` | Specifies the prefix for all resources created in this deployment. | `prefi` |
| `tags` | Specifies the tags that you want to apply to all resources. | {`key`: `value`} |
| `purviewRootCollectionAdminObjectIds` | Specifies the list of user object IDs that are assigned as collection admin to the root collection in Purview. | [`{object-id-1}`, `{object-id-2}`] |
| `purviewRootCollectionAdminObjectIds` | Specifies the list of user object IDs that are assigned as collection admin to the root collection in Purview. To get the object ID for a user use the following Azure CLI command: `az ad user list --display-name "{user name}" --query "[].objectId"`. | [`{object-id-1}`, `{object-id-2}`] |
| `vnetAddressPrefix` | Specifies the address space of the vnet. | `10.0.0.0/16` |
| `azureFirewallSubnetAddressPrefix` | Specifies the address space of the subnet that is use for Azure Firewall. | `10.0.0.0/24` |
| `servicesSubnetAddressPrefix` | Specifies the address space of the subnet that is used for the services. | `10.0.1.0/24` |
Expand Down
2 changes: 1 addition & 1 deletion docs/EnterpriseScaleAnalytics-GitHubActionsDeployment.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ To begin, please open the [infra/params.dev.json](/infra/params.dev.json). In th
| `environment` | Specifies the environment of the deployment. | `dev`, `tst` or `prd` |
| `prefix` | Specifies the prefix for all resources created in this deployment. | `prefi` |
| `tags` | Specifies the tags that you want to apply to all resources. | {`key`: `value`} |
| `purviewRootCollectionAdminObjectIds` | Specifies the list of user object IDs that are assigned as collection admin to the root collection in Purview. To get the object ID for a user use the following Azure CLI command: `az ad user list --display-name "{user name}" --query "[].objectId"` | [`{object-id-1}`, `{object-id-2}`] |
| `purviewRootCollectionAdminObjectIds` | Specifies the list of user object IDs that are assigned as collection admin to the root collection in Purview. To get the object ID for a user use the following Azure CLI command: `az ad user list --display-name "{user name}" --query "[].objectId"`. | [`{object-id-1}`, `{object-id-2}`] |
| `vnetAddressPrefix` | Specifies the address space of the vnet. | `10.0.0.0/16` |
| `azureFirewallSubnetAddressPrefix` | Specifies the address space of the subnet that is use for Azure Firewall. | `10.0.0.0/24` |
| `servicesSubnetAddressPrefix` | Specifies the address space of the subnet that is used for the services. | `10.0.1.0/24` |
Expand Down
6 changes: 3 additions & 3 deletions docs/EnterpriseScaleAnalytics-ServicePrincipal.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ az role assignment create \
--role "{roleName}" \
--scope "{scope}"

# Resource group scope level assignment (below one is for the Data Landing Zones only)
# Resource group scope level assignment (below command is required for the Data Landing Zone)
az role assignment create \
--assignee "{servicePrincipalObjectId}" \
--role "{roleName}" \
Expand All @@ -76,13 +76,13 @@ New-AzRoleAssignment `
-RoleDefinitionName "{roleName}" `
-Scope "{scope}"

# For Resource group scope level assignment (below one is for the Data Landing Zones only)
# For Resource group scope level assignment (below command is required for the Data Landing Zone)
New-AzRoleAssignment `
-ObjectId $spObjectId `
-RoleDefinitionName "{roleName}" `
-ResourceGroupName "{resourceGroupName}"

# For Child-Resource Scope level assignment (below one is for the Data Landing Zones only)
# For Child-Resource Scope level assignment (below command is required for the Data Landing Zone)
New-AzRoleAssignment `
-ObjectId $spObjectId `
-RoleDefinitionName "{roleName}" `
Expand Down