Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix All-in-one Template Bug #253

Merged
merged 1 commit into from
Dec 13, 2021
Merged

Fix All-in-one Template Bug #253

merged 1 commit into from
Dec 13, 2021

Conversation

marvinbuss
Copy link
Collaborator

This PR fixes
Fix validation Issue in all-in-one template.

@marvinbuss marvinbuss added bug Something isn't working committed Committed item labels Dec 13, 2021
@marvinbuss marvinbuss added this to the v1.2.0 milestone Dec 13, 2021
@marvinbuss marvinbuss self-assigned this Dec 13, 2021
@marvinbuss marvinbuss requested a review from a team as a code owner December 13, 2021 09:37
@marvinbuss marvinbuss linked an issue Dec 13, 2021 that may be closed by this pull request
Bug Report: All-in-one Template is broken #254
Closed
@marvinbuss
Copy link
Collaborator Author

marvinbuss commented Dec 13, 2021 •
edited
Loading

AIO Deployment
Preview Link

Bastion Deployment
Preview Link

@marvinbuss
Copy link
Collaborator Author

This PR makes the validation pass again:
image

@marvinbuss
Copy link
Collaborator Author

Full deployment worked successfully:
image

marvinbuss
marvinbuss commented Dec 13, 2021
View reviewed changes
Copy link
Collaborator Author

@marvinbuss marvinbuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marvinbuss marvinbuss merged commit 0203bcb into main Dec 13, 2021
@marvinbuss marvinbuss deleted the marvinbuss/bugfix branch December 13, 2021 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esbran esbran esbran approved these changes

Assignees

@marvinbuss marvinbuss

Labels
bug Something isn't working committed Committed item
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.

Bug Report: All-in-one Template is broken
2 participants
@marvinbuss @esbran