Skip to content
This repository has been archived by the owner on Oct 12, 2023. It is now read-only.

Fix: Test Coverage on Azure Pipeline CI #348

Merged
merged 29 commits into from
Feb 14, 2019
Merged

Fix: Test Coverage on Azure Pipeline CI #348

merged 29 commits into from
Feb 14, 2019

Conversation

brnleehng
Copy link
Collaborator

Fixed tests for Azure Pipeline CI

@lintr-bot
Copy link

tests/testthat/utility.R:36:29: style: Use <-, not =, for assignment.

settings['credentials'] = list(
                            ^

Copy link

@bgklein bgklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a couple nit's/clarification comments

samples/caret/caret_example.R Outdated Show resolved Hide resolved

sudo apt-get update
sudo apt-get install -y r-base r-base-dev libcurl4-openssl-dev
sudo apt-get install -y libssl-dev libxml2-dev libgdal-dev libproj-dev libgsl-dev
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not combine these two installs?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build script is for installing R in general. This would be used in multiple jobs since testthat does not support parallelism

tests/test_scripts/sample_test.sh Outdated Show resolved Hide resolved
tests/test_scripts/unit_tests.sh Outdated Show resolved Hide resolved
@brnleehng brnleehng merged commit 9758580 into master Feb 14, 2019
@brnleehng brnleehng deleted the fix/tests branch February 14, 2019 05:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants