This repository has been archived by the owner on Oct 12, 2023. It is now read-only.
Fix: Upgrading to R Batch SDK to 2018-12-01.8.0 #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
R/doAzureParallel.R:681:6: style: Commented code should be removed. #mergeResourceFileUrl <- paste0(mergeResourceFileUrl, "&restype=container")
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ |
bgklein
reviewed
Jun 12, 2019
| else { | ||
| resourceFiles <- | ||
| list(environmentResourceFile) | ||
| } |
There was a problem hiding this comment.
Shouldn't this be reversed if null set to list else append to existing list?
bgklein
reviewed
Jun 12, 2019
| @@ -533,9 +523,7 @@ waitForTasksToComplete <- | |||
| jobId) | |||
| } | |||
|
|
|||
| if (taskCounts$completed >= totalTasks && | |||
There was a problem hiding this comment.
Counting service notoriously runs into problems. Might need to change to doing smart list calls in the future.
There was a problem hiding this comment.
I've added job state in the check
bgklein
approved these changes
Jun 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing custom R container image in the merge task