-
Notifications
You must be signed in to change notification settings - Fork 391
Added instructions for Google Container Registry #116
Conversation
These changes are known to work with Google Container Registry. The existing instructions were insufficient. Reference here: https://cloud.google.com/container-registry/docs/advanced-authentication#using_an_access_token I blogged about running Draft on Google Container Engine: https://medium.com/@DazWilkin/azure-draft-on-google-container-engine-d1b25530a313
@DazWilkin, It will cover your contributions to all Microsoft-managed open source projects. |
|
||
``` | ||
$ echo '{"registrytoken":"9cbaf023786cd7"}' | base64 | ||
``` | ||
|
||
### For Google Container Registry: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind making the other topics like token-based auth a header as well for consistency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, I'm not going to be able to accept the CLA.
Unless I hear otherwise, I'll revert this tomorrow morning.
Apologies for the inconvenience.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh no that's a shame!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:'(
|
||
``` | ||
$ ACCESS_TOKEN=$(gcloud auth application-default print-access-token) | ||
$ AUTH_TOKEN=$(echo "{\"username\":\"_token\",\"password\":\"$ACCESS_TOKEN\"}" | base64 --wrap=0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might want to make this -w 0
instead, as both GNU and darwin base64
both understand the short form.
closing in favour of #154 as this documentation will all be going away with the |
These changes are known to work with Google Container Registry.
The existing instructions were insufficient.
Reference here:
https://cloud.google.com/container-registry/docs/advanced-authentication#using_an_access_token
I blogged about running Draft on Google Container Engine:
https://medium.com/@DazWilkin/azure-draft-on-google-container-engine-d1b25530a313