Update Pop Receipt #1066
Merged
Update Pop Receipt #1066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @wsugarman, just to confirm, is this PR ready to be merged? |
| @@ -59,10 +59,10 @@ await this.queueClient | |||
| this.stats.MessagesSent.Increment(); | |||
| } | |||
|
|
|||
| public async Task UpdateMessageAsync(QueueMessage queueMessage, TimeSpan visibilityTimeout, Guid? clientRequestId = null, CancellationToken cancellationToken = default) | |||
| public async Task<UpdateReceipt> UpdateMessageAsync(QueueMessage queueMessage, TimeSpan visibilityTimeout, Guid? clientRequestId = null, CancellationToken cancellationToken = default) | |||
There was a problem hiding this comment.
@wsugarman: is there a reason not to put the the popReceipt-updating logic here (in UpdateMessageAsync)? I think I'd rather have it here than sprinkled all throughout the callers, where I think it's more likely for folks to forget that they need to capture the output and manually update the receipt.
I think you could change the parameter types here to update the message object in-place
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the pop receipt for messages once they have been updated.