Remove Wrong Core Entities Error Handling #1103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmrdavid
approved these changes
May 28, 2024
| @@ -564,8 +564,6 @@ void DetermineWork(OrchestrationRuntimeState runtimeState, out SchedulerState sc | |||
|
|
|||
| break; | |||
|
|
|||
| default: | |||
There was a problem hiding this comment.
let's please create a GH issue tracking that we do want some error handling here, but that we'll need to add it on a later release, with sufficient testing, due to this regression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever core entities start, they will generate both
OrchestratorStartedandOrchestratorCompletedevents. The DetermineWork function checks all events of entities' runtime status. Therefore, the default error handling is not appropriate, as it should at least exclude these two events from being caught.Fixes #1095