Optimize Continue As New And Solve Missed Raised Events #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: this fixes Azure/azure-functions-durable-extension#67 |
cgillum
reviewed
Jan 19, 2019
Test/DurableTask.AzureStorage.Tests/AzureStorageScenarioTests.cs
Outdated
Show resolved
Hide resolved
Test/DurableTask.AzureStorage.Tests/AzureStorageScenarioTests.cs
Outdated
Show resolved
Hide resolved
src/DurableTask.AzureStorage/AzureStorageOrchestrationService.cs
Outdated
Show resolved
Hide resolved
src/DurableTask.Core/Command/OrchestrationCompleteOrchestratorAction.cs
Outdated
Show resolved
Hide resolved
src/DurableTask.Core/Command/OrchestrationCompleteOrchestratorAction.cs
Outdated
Show resolved
Hide resolved
test/DurableTask.ServiceBus.Tests/ServiceBusOrchestrationServiceTests.cs
Outdated
Show resolved
Hide resolved
Test/DurableTask.AzureStorage.Tests/AzureStorageScenarioTests.cs
Outdated
Show resolved
Hide resolved
cgillum
approved these changes
Jan 22, 2019
|
Need to add one more change for the azurestorageprovider which is to also commit the old runtime state if it is instance store backed |
cgillum
reviewed
Jan 22, 2019
src/DurableTask.AzureStorage/AzureStorageOrchestrationService.cs
Outdated
Show resolved
Hide resolved
timjl
reviewed
Jan 22, 2019
src/DurableTask.AzureStorage/AzureStorageOrchestrationService.cs
Outdated
Show resolved
Hide resolved
timjl
reviewed
Jan 22, 2019
| @@ -13,8 +13,16 @@ | |||
|
|
|||
| namespace DurableTask.Core.Command | |||
| { | |||
|
|
|||
simonporter
reviewed
Jan 22, 2019
src/DurableTask.Core/Command/OrchestrationCompleteOrchestratorAction.cs
Outdated
Show resolved
Hide resolved
| continuedAsNew = false; | ||
| continuedAsNewMessage = null; | ||
|
|
||
| TraceHelper.TraceInstance( | ||
| TraceEventType.Verbose, |
cgillum
reviewed
Jan 22, 2019
src/DurableTask.AzureStorage/Tracking/InstanceStoreBackedTrackingStore.cs
Show resolved
Hide resolved
shankarsama
pushed a commit
to shankarsama/durabletask
that referenced
this pull request
Apr 27, 2021
* Optimize Continue As New And Solve Missed Events * make skip events property driven * Commit old state in case of an instance store backed tracking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to optimize ContinueAsNew so that an orchestration continues in memory in the dispatcher if it can instead of enqueueing a new task message.
With this Events Raised After a continueAsNew has been executed will also be collected and carried over to the next iteration of the orchestration. This a feature that can be opted out of by specifying SkipEventsOnContinuation as true in the OrchestrationService.