Added Options to Configure Behavior When Starting a New Orchestrator With an Existing Instance Id #325
Conversation
There was a problem hiding this comment.
This is a good start, but I don't think it's sufficient to fix the problem. If multiple threads call CreateTaskOrchestrationAsync at the same time, they will all see that existingInstance is null and all threads will try to create new instances. Locks won't help because it's also possible that the function app is scaled out and these calls are coming from two different nodes. To make this effective in all cases, we also need to update the code that reads these messages.
I think the two places which would need to check for these "ExecutionStarted" messages are here and here.
We should also add one or more tests to validate this new behavior.
| @@ -1244,6 +1244,12 @@ public async Task CreateTaskOrchestrationAsync(TaskMessage creationMessage, Orch | |||
| return; | |||
| } | |||
|
|
|||
| if (existingInstance != null && !OverrideConditionsMet(existingInstance.OrchestrationStatus)) | |||
There was a problem hiding this comment.
Could we achieve the same outcome if we simply depended on the existing dedupeStatuses parameter? I don't have an good answer for this that I can think of right now, but something to consider.
| if (existingInstance != null && !OverrideConditionsMet(existingInstance.OrchestrationStatus)) | ||
| { | ||
| // An instance in a state that is configured to not be overridable already exists | ||
| return; |
There was a problem hiding this comment.
I think we should throw an InvalidOperationException in this case. Otherwise customers might not realize that their attempt to start an orchestration was ignored.
|
Closing this PR. Decided to use dedupe status instead and modify code in azure-functions-durable-extension. Azure/azure-functions-durable-extension#987 |
Added options to configure which states you want to override an existing orchestrator instance id when attempting to start a new instance.
Fixes this issue in the azure-functions-durable-extension repository
Azure/azure-functions-durable-extension#367