Improve logging for lease management #723
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was doing some manual testing of the lease management code to try and diagnose some issues we've been facing recently and found a few places where we could use some improvements. Here are the changes in this PR:
ObjectDisposedException
when restarting the task hub worker (reported by an internal DTFx user).I found some more fundamental lease management issues as well, but I'll try to tackle those in a separate PR.