Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide "remove additional files at destination" #33

Closed
Scooletz opened this issue May 8, 2020 · 8 comments
Closed

Provide "remove additional files at destination" #33

Scooletz opened this issue May 8, 2020 · 8 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@Scooletz
Copy link

Scooletz commented May 8, 2020

After going through documentations I found no information about it, so I'm raising this issue.

Remove additional files at destination as in Azure/Azure-Functions#564 is not available as a publish option.

@AmrutaKawade
Copy link
Contributor

AmrutaKawade commented Aug 20, 2020

Remove additional files at destination option is available in msdeploy. For function action we use kudu zip deploy method for deployment. as per kudu documentation

Deletion of files no longer in the build: When a new build is deployed with zipdeploy, files and directories that were created by the previous deployment but are no longer present in the build will be deleted. Any other files and directories found in the site that aren't being overwritten by the deployment, such as those placed there via FTP or created by your app during runtime, will be preserved.

It should be handled automatically

@AmrutaKawade AmrutaKawade self-assigned this Aug 31, 2020
@Scooletz
Copy link
Author

Scooletz commented Sep 8, 2020

Thank you for the response @AmrutaKawade I'm aware of the kudu zip deploy, but I fail to find it in the documentation for this actions provided on the action page https://github.com/marketplace/actions/azure-functions-action

@AmrutaKawade AmrutaKawade added the documentation Improvements or additions to documentation label Sep 8, 2020
@20shivangi
Copy link
Contributor

@N-Usha Please check this issue. Some things are missing in documentation.

@AmrutaKawade AmrutaKawade added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Sep 10, 2020
@20shivangi 20shivangi removed their assignment Sep 10, 2020
@N-Usha
Copy link
Contributor

N-Usha commented Sep 18, 2020

I added this detail to the documentation. Closing this issue. Thanks!

@N-Usha N-Usha closed this as completed Sep 18, 2020
@Scooletz
Copy link
Author

Scooletz commented Sep 18, 2020

Hey @N-Usha for sake of reference I'm adding the commit that addresses this issue 16fca3c

@Scooletz
Copy link
Author

@AmrutaKawade According to the updated doc

"Remove additional files at destination" is not supported by Kudu deploy method which is used in this action and should be handled separately.

so I think that your comment #33 (comment) might not be applicable. As far as I see it, it makes this issue valid again, because it intent was not to have a documentation updated, but rather address the lack of functionality.

@maximivanov
Copy link

I've just confirmed the following (undesired) scenario:

  1. New file added to git and branch pushed to Github
  2. Deployment triggered with functions-action in it. Destination: Linux Premium Function App
  3. I can see the new file on the Function App / App Files page in Azure Portal
  4. I remove the file and commit/push
  5. Deployment triggered
  6. File is still visible in the App Files.

I was exploring Github Actions as a replacement for an Azure DevOps pipeline (that would make our setup much simpler) but with this missing feature I don't think it's ready yet. Hopefully it's on the roadmap.

@JasonKleban
Copy link

So @N-Usha, how do we delete old functions?

The Azure portal shows

image

And there's no obvious way to get a yaml deployment with azure/azure-functions to clear them out? And by not clearing them out, I see a bunch of ERROR noise in my logs at app startup regarding bad bindings for functions that I've already deleted in my source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

8 participants