Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.funcignore is (still) not respected #62

Closed
maximivanov opened this issue Jan 15, 2021 · 4 comments · Fixed by #68
Closed

.funcignore is (still) not respected #62

maximivanov opened this issue Jan 15, 2021 · 4 comments · Fixed by #68
Assignees
Labels
enhancement New feature or request

Comments

@maximivanov
Copy link

Recreating #36 (comment) as an issue for better visibility:

I gave this action a try and I can still see .funcignored files deployed to the target host.

Here's the repo to reproduce: https://github.com/maximivanov/azure-functions-cd-github-actions

respect-funcignore: true is set on the functions-action in the workflow file.
Among others, .funcignore includes .gitignore.

Once cloud resources are provisioned (I use Terraform for that), I trigger the CD workflow in the repo.

Expected:
.gitignore is not deployed.

Actual:
I can see .gitignore in the app files section in the Portal.

Screen Shot 2020-12-18 at 22 34 42

@N-Usha @Hazhzeng

Let me know if you need any further details. Thanks!

@aksm-ms
Copy link
Contributor

aksm-ms commented Jan 19, 2021

@maximivanov Are you seeing any files from funcignore apart from ".gitignore" in the app files?

@maximivanov
Copy link
Author

@aksm-ms it seems that funcignore has no effect on files prefixed with . (dot).

randomfile.txt was ignored
randomfile-noextension was ignored
.randomfile-dotprefix was deployed (I could see it in the App Files in Azure Portal).

@20shivangi
Copy link
Contributor

@N-Usha Should we mark this as an enhancement?

@brc-dd
Copy link

brc-dd commented Mar 31, 2021

This should have been marked bug instead of enhancement. :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants