Added support for unwrapped Azure API error responses #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalpristas
force-pushed
the
support-for-unwrapped-errors
branch
from
2cdb55b to
d9ee4b3
Compare
marstr
suggested changes
Sep 13, 2017
autorest/azure/azure.go
Outdated
| e.ServiceError = se | ||
| } else { | ||
| e.ServiceError = &ServiceError{Code: "Unknown", Message: "Unknown service error"} | ||
| } |
There was a problem hiding this comment.
I believe this should be updated to:
var se ServiceError
if err := json.Unmarshal(b.Bytes(), &se); err == nil && se.Message != "" {
e.ServiceError = &se
} else {
e.ServiceError = &ServiceError{
Code: "Unknown",
Message: "Unknown service error",
}
}
autorest/azure/azure_test.go
Outdated
| WithErrorUnlessStatusCode(http.StatusOK), | ||
| autorest.ByClosing()) | ||
| if err == nil { | ||
| t.Fatalf("azure: returned nil error for proper error response") |
There was a problem hiding this comment.
Using t.Fatalf ends all test execution. Please update these calls to be of the pattern:
t.Logf("[your stuff]", [any args you need])
t.Fail()
autorest/azure/azure_test.go
Outdated
| } | ||
|
|
||
| details, _ := json.Marshal(*azErr.ServiceError.Details) | ||
| if string(details) != `[{"code":"conflict1","message":"error message1"},{"code":"conflict2","message":"error message2"}]` { |
There was a problem hiding this comment.
A Go idiom is to print out "got" and "want" in this case, one would expect the Unit Test Log to read the following on failure:
got: "{contents of details}"
want: "[{"code":"conflict1","message":"error message1"},{"code":"conflict2","message":"error message2"}]"
Mind refactoring this?
There was a problem hiding this comment.
i will prepare fix today
|
@marstr is something missing? |
|
Sorry, to leave you hanging @michalpristas! Thanks for making the recommended changes. Merging this in now. |
marstr
approved these changes
Oct 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should solve problem described here: Azure/azure-sdk-for-go#748
The problem is that result of API call is ServiceError itself, not ServiceError wrapped in error object. Which causes autorest to return 'Unknown' error instead.
Fixes: 748