Hotfix: update the logic to get path of access tokens. #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Add logic to read path of access tokens through environment variable. 2. Add fallback logic to default one. Notice: this is short-term fix and require user to use latest version of provider in Cloud Shell.
|
I could not find any legacy unit test for AccessTokensPath method. Let me know if we need to add it. |
marstr
suggested changes
Nov 16, 2017
autorest/azure/cli/token.go
Outdated
| var err error | ||
|
|
||
| // Fallback logic to default path on non-cloud-shell environment. | ||
| // TODO(sushi): remove the dependency on hard-coding path. |
There was a problem hiding this comment.
Instead of mentioning yourself, please open a new issue and mention it in this comment. :)
CHANGELOG.md
Outdated
|
|
||
| ### Bug Fixes | ||
|
|
||
| - Update the logic to get path of access tokens through AZURE_ACCESS_TOKEN_FILE. |
There was a problem hiding this comment.
Mind rephrasing this to make clear that the previous default still works?
|
@marstr let me create an issue as TODO item for the unit test. |
|
@marstr the PR is updated, when it's merged, please let me know. I will work with Tom to update the dependency on provider repo. |
marstr
approved these changes
Nov 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notice: this is short-term fix and require user to use latest version of provider in Cloud Shell.
Thank you for your contribution to Go-AutoRest! We will triage and review it as soon as we can.
As part of submitting, please make sure you can make the following assertions:
devbranch, except in the case of urgent bug fixes warranting their own release.master, I've updated CHANGELOG.md to address the changes I'm making.