Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add KeyVaultResourceURL #367

Merged
merged 4 commits into from
Apr 17, 2019
Merged

Add KeyVaultResourceURL #367

merged 4 commits into from
Apr 17, 2019

Conversation

karataliu
Copy link
Contributor

@karataliu karataliu commented Mar 8, 2019 •
edited
Loading

@jhendrixMSFT jhendrixMSFT self-assigned this Mar 8, 2019
xuto2
xuto2 suggested changes Mar 8, 2019
View reviewed changes
Copy link

@xuto2 xuto2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be KeyVaultResourceID

@karataliu karataliu force-pushed the kvuri branch 2 times, most recently from c2cf1ad to c6a03f6 Compare March 10, 2019 04:49
jhendrixMSFT
jhendrixMSFT requested changes Mar 13, 2019
View reviewed changes
Copy link
Member

@jhendrixMSFT jhendrixMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please separate into separate sub properties per discussion.

@ghost ghost added the review label Mar 13, 2019
jhendrixMSFT
jhendrixMSFT approved these changes Apr 10, 2019
View reviewed changes
Copy link
Member

@jhendrixMSFT jhendrixMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to review the NotAvailable resource IDs to ensure they're accurate.

vladbarosan
vladbarosan reviewed Apr 10, 2019
View reviewed changes
autorest/azure/environments.go Outdated
Datalake: NotAvailable,
MicrosoftGraph: NotAvailable,
Batch: "https://batch.chinacloudapi.cn/",
Storage: NotAvailable,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

storage is not available in all clouds ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect it is but couldn't find it anywhere. Hoping @yangl900 or somebody has the answer.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. Im worried than that saying NotAvailable might send the wrong message that storage is not available in that cloud.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this indicates storage-aad support is not available in all clouds.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it? I can't find any documentation on what the resource ID should be.

@jhendrixMSFT jhendrixMSFT merged commit 562d376 into Azure:master Apr 17, 2019
@karataliu karataliu deleted the kvuri branch February 19, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhendrixMSFT jhendrixMSFT jhendrixMSFT approved these changes

@yangl900 yangl900 yangl900 left review comments

@xuto2 xuto2 xuto2 requested changes

@vladbarosan vladbarosan vladbarosan approved these changes

Assignees

@jhendrixMSFT jhendrixMSFT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@karataliu @xuto2 @yangl900 @jhendrixMSFT @vladbarosan