feat: Use Azure Federated instead of kubelet identity #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helayoty
force-pushed
the
az-fed
branch
28 times, most recently
from
6bb2e61 to
8989f92
Compare
helayoty
force-pushed
the
az-fed
branch
3 times, most recently
from
8d918a9 to
b9169ff
Compare
Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>
Fei-Guo
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving to use Azure Federated Ideninty instead of Kubelet Identity as gpu-provisioner needs super permission in order to be able to manage agent pools, which is not secure to use the kubelet identity one with.
To be able to use gpu-provisioner,
client-idfor the new identityIn addition, we removed the unused config and environment variables.