-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new Buffer -> Buffer.from #62
base: master
Are you sure you want to change the base?
Conversation
any feedback on this? |
@paulbatum Is this repo still being maintained? |
@davidebbo @rramachand21 can this get merged? |
Can we get a merger on this? The warning persistently ends up in the logs and makes debugging real issues harder. |
How to fix below issue in nodev10 |
@anantksingh The fix is in this pull request, but it hasn't been merged yet. |
It cause issue with https ! |
@SuperstrongBE You can find the file on your server and modify it yourself if you need a quick fix. |
@UziTech when can this be merged? Fix has been tested so surely just click of a button now |
This is ready to be merged but I don't have push access and I don't think this repo is maintained. |
Sorry, I'm no longer at Microsoft, and neither is Ranjith. @ahmelsayed or @suwatch do you know who owns this now? |
From the Microsoft mailing lists, it seemed like the App Service team keeps an eye on the repo (according to Stefan Schackow). |
/cc @JennyLawrance |
@ahmelsayed Any chance this can be merged and a release done, now that the changes are approved? |
I think it's safe to say that this repo is no longer maintained. |
Best thing to do is migrate away from IISNODE |
Do you have any alternatives as to run Node.JS in cooperation with IIS? The only thing I can come up with right now is having multiple projects running using pm2 (https://www.npmjs.com/package/pm2) on different ports and having a reverse proxy rewrite rule on the websites in IIS (as documented on https://docs.microsoft.com/en-us/iis/extensions/url-rewrite-module/reverse-proxy-with-url-rewrite-v2-and-application-request-routing). This is something I am in process of testing and I wonder how other people do it nowadays. |
I ended up with pm2 running my expressjs apps and nginx as the web server. A bit of config needed but once I got it running its been very stable |
@DjovDev HttpPlatformHandler has been a stable alternative from Microsoft since 2015, https://docs.lextudio.com/blog/running-nodejs-web-apps-on-iis-with-httpplatformhandler/ |
from tjanczuk#636
new Buffer(string, encoding)
is deprecated in Node v6it changes to
Buffer.from(string, encoding)