Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new Buffer -> Buffer.from #62

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

new Buffer -> Buffer.from #62

wants to merge 3 commits into from

Conversation

UziTech
Copy link

@UziTech UziTech commented Sep 7, 2018

from tjanczuk#636


new Buffer(string, encoding) is deprecated in Node v6
it changes to Buffer.from(string, encoding)

@UziTech
Copy link
Author

UziTech commented Apr 23, 2019

any feedback on this?

@curtgrimes
Copy link

@paulbatum Is this repo still being maintained?

@UziTech
Copy link
Author

UziTech commented Jul 31, 2019

@davidebbo @rramachand21 can this get merged?

@szul
Copy link

szul commented Sep 9, 2019

Can we get a merger on this? The warning persistently ends up in the logs and makes debugging real issues harder.

@anantksingh
Copy link

How to fix below issue in nodev10
(node:14324) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.

@szul
Copy link

szul commented Sep 18, 2019

@anantksingh The fix is in this pull request, but it hasn't been merged yet.

@SuperstrongBE
Copy link

It cause issue with https !
Please merge !

@szul
Copy link

szul commented Nov 25, 2019

@SuperstrongBE You can find the file on your server and modify it yourself if you need a quick fix.

@JoeEarly
Copy link

@UziTech when can this be merged? Fix has been tested so surely just click of a button now

@UziTech
Copy link
Author

UziTech commented Feb 15, 2020

This is ready to be merged but I don't have push access and I don't think this repo is maintained.

@UziTech
Copy link
Author

UziTech commented Feb 15, 2020

@davidebbo @rramachand21

@davidebbo
Copy link

Sorry, I'm no longer at Microsoft, and neither is Ranjith. @ahmelsayed or @suwatch do you know who owns this now?

@szul
Copy link

szul commented Feb 15, 2020

From the Microsoft mailing lists, it seemed like the App Service team keeps an eye on the repo (according to Stefan Schackow).

@ahmelsayed
Copy link

/cc @JennyLawrance

@dpolivy
Copy link

dpolivy commented Sep 3, 2020

@ahmelsayed Any chance this can be merged and a release done, now that the changes are approved?

@curtgrimes
Copy link

I think it's safe to say that this repo is no longer maintained.

@JoeEarly
Copy link

JoeEarly commented Sep 4, 2020

Best thing to do is migrate away from IISNODE

@DjovDev
Copy link

DjovDev commented Jan 4, 2021

Best thing to do is migrate away from IISNODE

Do you have any alternatives as to run Node.JS in cooperation with IIS?

The only thing I can come up with right now is having multiple projects running using pm2 (https://www.npmjs.com/package/pm2) on different ports and having a reverse proxy rewrite rule on the websites in IIS (as documented on https://docs.microsoft.com/en-us/iis/extensions/url-rewrite-module/reverse-proxy-with-url-rewrite-v2-and-application-request-routing).

This is something I am in process of testing and I wonder how other people do it nowadays.

@JoeEarly
Copy link

JoeEarly commented Jan 4, 2021

Best thing to do is migrate away from IISNODE

Do you have any alternatives as to run Node.JS in cooperation with IIS?

The only thing I can come up with right now is having multiple projects running using pm2 (https://www.npmjs.com/package/pm2) on different ports and having a reverse proxy rewrite rule on the websites in IIS (as documented on https://docs.microsoft.com/en-us/iis/extensions/url-rewrite-module/reverse-proxy-with-url-rewrite-v2-and-application-request-routing).

This is something I am in process of testing and I wonder how other people do it nowadays.

I ended up with pm2 running my expressjs apps and nginx as the web server. A bit of config needed but once I got it running its been very stable

@lextm
Copy link

lextm commented May 2, 2024

@DjovDev HttpPlatformHandler has been a stable alternative from Microsoft since 2015, https://docs.lextudio.com/blog/running-nodejs-web-apps-on-iis-with-httpplatformhandler/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.