Skip to content
This repository has been archived by the owner on Oct 12, 2023. It is now read-only.

Remove unused build script option #123

Merged
merged 1 commit into from
Feb 7, 2017
Merged

Remove unused build script option #123

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions tools/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

set -e

build_clean=
build_root=$(cd "$(dirname "$0")/.." && pwd)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

d_r [](start = 4, length = 3)

It would actually be so nice if this script would die a horrible death.
I think all the options handled by this script can be directly passed to cmake, isn't it. It seems this script is an extra abstraction layer that is not really necessary ...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally agree, and I think that will happen in the not too distant future.

local_install=$build_root/install-deps
log_dir=$build_root
Expand All @@ -27,7 +26,6 @@ usage ()
echo " -f, --config <value> Build specified configuration. Default value is 'Debug'"
echo " --rebuild-deps Force re-build of dependencies"
echo " -x, --xtrace Print a trace of each command"
echo " -c, --clean Remove previous build artifacts"
echo " -cl, --compileoption <value> Specify a gcc compile option"
echo " Example: -cl -O1 -cl ..."
echo " -rv, --run-valgrind Execute ctest with valgrind"
Expand All @@ -47,7 +45,6 @@ usage ()

process_args ()
{
build_clean=0
save_next_arg=0
extracloptions=" "

Expand All @@ -71,7 +68,6 @@ process_args ()
else
case "$arg" in
"-x" | "--xtrace" ) set -x;;
"-c" | "--clean" ) build_clean=1;;
"--run-unittests" ) run_unittests=ON;;
"--run-e2e-tests" ) run_e2e_tests=ON;;
"--rebuild-deps" ) rebuild_deps=ON;;
Expand Down