This repository has been archived by the owner on Oct 12, 2023. It is now read-only.
Fix JNIEnv* share between start thread and receive thread #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit moves JNIEnv* variable from JAVA_MODULE_HANDLE_DATA structure to local variable. The variable is assigned by JVM in AttachCurrentThread in both of start and receive functions, it causes race condition of the variable, then segmentation fault is occurred in ExceptionOccurred JNI function. So, the JNIEnv* variable should be local instead of a part of JAVA_MODULE_HANDLE_DATA.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #275.
This commit moves
JNIEnv*variable fromJAVA_MODULE_HANDLE_DATAstructure to local variable.The variable is assigned by JVM in
AttachCurrentThreadin both of start and receive functions,it causes race condition of the variable, then segmentation fault is occurred in
ExceptionOccurredJNI function.So, the
JNIEnv*variable should be local instead of a part ofJAVA_MODULE_HANDLE_DATA.