Unbuntu Core - configure hook, extensions registration, and folders owner/user changes #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use snapcraft environment vars in snapcraft.yaml - Update doc - Remove install and post-refresh hooks - Update configure hook to setup dirs and register extensions - Create extension registration dirs using current user id and group id.
- Add 'home' interface to the snap - Update document - Disable the Agent's 'command' support
jw-msft
approved these changes
Dec 1, 2022
- calling /usr/bin/curl-downloader (symlink to $SNAP/usr/bin/curl) for file download - change ADUC_FILE_USER to 'root'
shiyi-peng
reviewed
Dec 2, 2022
| ```sh | ||
| snap run --shell deviceupdate-agent | ||
| ```shell | ||
| $ cp <home-dir>/du-config.json $SNAP_DATA/config |
There was a problem hiding this comment.
I used vi, but a little unsure about the cp here. Is it run inside the device-update snap shell? how do we specify the ?
There was a problem hiding this comment.
Yes, this should be run inside the snap shell. Customer can choose their preferred method to author the du-config.json. As long as it is placed in the right location ($SNAP_DATA/config/du-config.json)
shiyi-peng
approved these changes
Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
snapenvironment (executing curl from $SNAP/usr/bin/curl)