Under Strict Confinement - AzIoTIdentity integration #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nox-MSFT
approved these changes
Mar 17, 2023
nihemstr
requested changes
Mar 20, 2023
src/agent/src/main.c
Outdated
| @@ -1395,6 +1395,8 @@ int main(int argc, char** argv) | |||
|
|
|||
| ADUC_Logging_Init(launchArgs.logLevel, "du-agent"); | |||
|
|
|||
| printf("Current UID : %d\n", geteuid()); | |||
There was a problem hiding this comment.
nit: Do we need to keep the UID in the log?
src/utils/eis_utils/src/eis_utils.c
Outdated
| * @param[in] filePath the path of the EIS response named pipe | ||
| * returns EISErr value | ||
| */ | ||
| // EISErr EISIdentitiesFileWriter(uint32_t timeoutMS, const char* filePath) |
There was a problem hiding this comment.
why are we checking in large blocks of commented out code?
src/utils/eis_utils/src/eis_utils.c
Outdated
| // * @returns on success a null terminated connection string, otherwise NULL | ||
| // */ | ||
| // EISUtilityResult RequestConnectionStringFromEISWithExpiry( | ||
| // const time_t expirySecsSinceEpoch, uint32_t timeoutMS, ADUC_ConnectionInfo* provisioningInfo) |
There was a problem hiding this comment.
More commented out code...
nihemstr
approved these changes
Mar 21, 2023
author Shiyi Peng <shiyipeng@microsoft.com> 1679043264 -0700 committer Shiyi Peng <shiyipeng@microsoft.com> 1679564684 -0700 EIS integration snapcraft.yaml named pipe not working change back to file revert back to file fix UT tested working add support strict confinement fix tested working EIS with strict confinement
shiyi-peng
force-pushed
the
user/shiyipeng/eis-snap-new
branch
from
579a3a4
to
e71c5a6
Compare
shiyi-peng
changed the title
shiyi-peng
added a commit
that referenced
this pull request
May 8, 2023
shiyi-peng
added a commit
that referenced
this pull request
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging to feature/snap