Skip to content

Commit

Permalink
Update all uses of checkout, upload-artifact and download-artifact Ac…
Browse files Browse the repository at this point in the history
…tions to v3. (#492)

CI has been reporting warnings for some time.

>Node.js 12 actions are deprecated. For more information see:
>https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

Also switch the workflows to run on Ubuntu 22.04.
  • Loading branch information
arsing authored Dec 8, 2022
1 parent a9c96ae commit 0236a86
Show file tree
Hide file tree
Showing 4 changed files with 32 additions and 32 deletions.
16 changes: 8 additions & 8 deletions .github/workflows/e2e-tests-manual.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@ on:

jobs:
suite-setup:
runs-on: 'ubuntu-18.04'
runs-on: 'ubuntu-22.04'

steps:
- uses: 'actions/checkout@v1'
- uses: 'actions/checkout@v3'
with:
ref: "${{ github.event.inputs.branch }}"

Expand All @@ -39,7 +39,7 @@ jobs:
test-run:
needs: 'suite-setup'

runs-on: 'ubuntu-18.04'
runs-on: 'ubuntu-22.04'

strategy:
fail-fast: false
Expand All @@ -63,7 +63,7 @@ jobs:
max-parallel: 10

steps:
- uses: 'actions/checkout@v1'
- uses: 'actions/checkout@v3'
with:
ref: "${{ github.event.inputs.branch }}"

Expand Down Expand Up @@ -104,10 +104,10 @@ jobs:
needs: 'test-run'
if: "${{ success() }}"

runs-on: 'ubuntu-18.04'
runs-on: 'ubuntu-22.04'

steps:
- uses: 'actions/checkout@v1'
- uses: 'actions/checkout@v3'
with:
ref: "${{ github.event.inputs.branch }}"

Expand All @@ -127,10 +127,10 @@ jobs:
needs: 'test-run'
if: "${{ failure() }}"

runs-on: 'ubuntu-18.04'
runs-on: 'ubuntu-22.04'

steps:
- uses: 'actions/checkout@v1'
- uses: 'actions/checkout@v3'
with:
ref: "${{ github.event.inputs.branch }}"

Expand Down
16 changes: 8 additions & 8 deletions .github/workflows/e2e-tests-scheduled.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
suite-setup:
if: "github.repository == 'Azure/iot-identity-service'"

runs-on: 'ubuntu-18.04'
runs-on: 'ubuntu-22.04'

strategy:
fail-fast: false
Expand All @@ -32,7 +32,7 @@ jobs:
max-parallel: 10

steps:
- uses: 'actions/checkout@v1'
- uses: 'actions/checkout@v3'
with:
ref: "${{ matrix.branch }}"

Expand All @@ -52,7 +52,7 @@ jobs:
if: "github.repository == 'Azure/iot-identity-service'"
needs: 'suite-setup'

runs-on: 'ubuntu-18.04'
runs-on: 'ubuntu-22.04'

strategy:
fail-fast: false
Expand Down Expand Up @@ -83,7 +83,7 @@ jobs:
max-parallel: 10

steps:
- uses: 'actions/checkout@v1'
- uses: 'actions/checkout@v3'
with:
ref: "${{ matrix.branch }}"

Expand Down Expand Up @@ -124,7 +124,7 @@ jobs:
if: "${{ github.repository == 'Azure/iot-identity-service' && success() }}"
needs: 'test-run'

runs-on: 'ubuntu-18.04'
runs-on: 'ubuntu-22.04'

strategy:
fail-fast: false
Expand All @@ -137,7 +137,7 @@ jobs:
max-parallel: 10

steps:
- uses: 'actions/checkout@v1'
- uses: 'actions/checkout@v3'
with:
ref: "${{ matrix.branch }}"

Expand All @@ -157,7 +157,7 @@ jobs:
needs: 'test-run'
if: "${{ failure() }}"

runs-on: 'ubuntu-18.04'
runs-on: 'ubuntu-22.04'

strategy:
fail-fast: false
Expand All @@ -170,7 +170,7 @@ jobs:
max-parallel: 10

steps:
- uses: 'actions/checkout@v1'
- uses: 'actions/checkout@v3'
with:
ref: "${{ matrix.branch }}"

Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/packages.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:

jobs:
packages:
runs-on: 'ubuntu-18.04'
runs-on: 'ubuntu-22.04'

strategy:
fail-fast: false
Expand Down Expand Up @@ -48,7 +48,7 @@ jobs:
os: 'mariner:2'

steps:
- uses: 'actions/checkout@v1'
- uses: 'actions/checkout@v3'
with:
submodules: 'recursive'
- name: 'Run'
Expand Down Expand Up @@ -81,7 +81,7 @@ jobs:
os_package="$(sed -e 's@[:/]@-@g' <<< "$os_package")"
echo "artifact-name=packages_${os_package}_${{ matrix.arch }}" >> $GITHUB_OUTPUT
- name: 'Upload'
uses: 'actions/upload-artifact@v1'
uses: 'actions/upload-artifact@v3'
with:
name: "${{ steps.generate-artifact-properties.outputs.artifact-name }}"
path: 'packages'
26 changes: 13 additions & 13 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ permissions:

jobs:
basic:
runs-on: 'ubuntu-18.04'
runs-on: 'ubuntu-22.04'

strategy:
fail-fast: false
Expand All @@ -28,7 +28,7 @@ jobs:
- 'amd64'

steps:
- uses: 'actions/checkout@v1'
- uses: 'actions/checkout@v3'
with:
submodules: 'recursive'
- name: 'Run'
Expand All @@ -54,7 +54,7 @@ jobs:
esac
echo "target_dir=$target_dir" >> $GITHUB_OUTPUT
- name: 'Upload'
uses: 'actions/upload-artifact@v2'
uses: 'actions/upload-artifact@v3'
with:
name: "${{ steps.generate-artifact-properties.outputs.artifact-name }}"
path: |
Expand All @@ -68,7 +68,7 @@ jobs:


aziot-key-openssl-engine-shared:
runs-on: 'ubuntu-18.04'
runs-on: 'ubuntu-22.04'

strategy:
fail-fast: false
Expand All @@ -95,7 +95,7 @@ jobs:
needs: 'basic'

steps:
- uses: 'actions/checkout@v1'
- uses: 'actions/checkout@v3'
with:
submodules: 'recursive'
- name: 'Generate artifact properties'
Expand All @@ -113,7 +113,7 @@ jobs:
echo "target_dir=$target_dir" >> $GITHUB_OUTPUT
- name: 'Download'
id: 'download-artifact'
uses: 'actions/download-artifact@v2'
uses: 'actions/download-artifact@v3'
with:
name: "${{ steps.generate-artifact-properties.outputs.artifact-name }}"
path: 'target/debug'
Expand All @@ -132,7 +132,7 @@ jobs:
PKCS11_BACKEND: "${{ matrix.pkcs11_backend }}"

mock-iot-tests:
runs-on: 'ubuntu-18.04'
runs-on: 'ubuntu-22.04'

strategy:
fail-fast: false
Expand All @@ -151,7 +151,7 @@ jobs:
needs: 'basic'

steps:
- uses: 'actions/checkout@v1'
- uses: 'actions/checkout@v3'
- name: 'Generate artifact properties'
id: 'generate-artifact-properties'
run: |
Expand All @@ -167,7 +167,7 @@ jobs:
echo "target_dir=$target_dir" >> $GITHUB_OUTPUT
- name: 'Download'
id: 'download-artifact'
uses: 'actions/download-artifact@v2'
uses: 'actions/download-artifact@v3'
with:
name: "${{ steps.generate-artifact-properties.outputs.artifact-name }}"
path: 'target/debug'
Expand All @@ -194,19 +194,19 @@ jobs:
SERVER_KEY: '/src/mock_iot_server_certs/server_cert_key.pem'

openapi:
runs-on: 'ubuntu-18.04'
runs-on: 'ubuntu-22.04'

steps:
- uses: 'actions/checkout@v1'
- uses: 'actions/checkout@v3'
- name: 'Test OpenAPI specs'
run: |
make target/openapi-schema-validated
codecoverage:
runs-on: 'ubuntu-18.04'
runs-on: 'ubuntu-22.04'

steps:
- uses: 'actions/checkout@v1'
- uses: 'actions/checkout@v3'
with:
submodules: 'recursive'

Expand Down

0 comments on commit 0236a86

Please sign in to comment.