Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Facade auth code from the logs #1916

Closed
kbeaugrand opened this issue Oct 25, 2022 · 3 comments · Fixed by #1955
Closed

Remove the Facade auth code from the logs #1916

kbeaugrand opened this issue Oct 25, 2022 · 3 comments · Fixed by #1955
Labels
bug Something isn't working

Comments

@kbeaugrand
Copy link
Collaborator

Expected Behavior

Credentials should be obfuscated event in logs.

Current Behavior

On the LoRaWANNetworkSrvModule we can see in clear the Facade auth code

image

Steps to Reproduce

  1. Go the the LoRaWANNetworkSrvModule logs

Context (Environment)

Device (Host) Operating System

N/A

Architecture

N/A

Container Operating System

Linux containers

LoRaWAN Module Version

2.2.0

Docker

N/A

Logs

Additional Information

@kbeaugrand kbeaugrand added the bug Something isn't working label Oct 25, 2022
@Mandur Mandur added this to the S03E02 - milestone Oct 26, 2022
@Mandur
Copy link
Contributor

Mandur commented Oct 26, 2022

Hello @kbeaugrand

Thank you for reporting this, we will have a look

@Mandur
Copy link
Contributor

Mandur commented Oct 26, 2022

By adding the environment variable
"Logging:LogLevel:System": "Warning"
should disable this behavior, we will move into integrating this in upstream.

@kbeaugrand
Copy link
Collaborator Author

Fine, that works, but we do not have any logs about query executed on the Facade.
Not a big deal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants