Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change log verbosity for the HTTP client #1955

Merged
merged 5 commits into from
Nov 1, 2022
Merged

Change log verbosity for the HTTP client #1955

merged 5 commits into from
Nov 1, 2022

Conversation

Mandur
Copy link
Contributor

@Mandur Mandur commented Nov 1, 2022

PR for issue #1916

What is being addressed

  • Change the default log verbosity to be 'Warning' for the HTTP client to avoid leaking function auth code in the logs
  • Change path to the Notice.txt to make it available in the final image.

Tests

The following E2E run deployed this bits, as you can see we dot not see anymore the function URLS
https://github.com/Azure/iotedge-lorawan-starterkit/actions/runs/3368555574/jobs/5587427871

@Mandur Mandur temporarily deployed to CI November 1, 2022 10:01 Inactive
@Mandur Mandur added the fullci Run full continuous integration label Nov 1, 2022
@Mandur Mandur temporarily deployed to CI November 1, 2022 10:01 Inactive
@Mandur Mandur temporarily deployed to CI November 1, 2022 10:01 Inactive
@Mandur Mandur temporarily deployed to CI November 1, 2022 10:01 Inactive
@Mandur Mandur temporarily deployed to CI November 1, 2022 10:01 Inactive
@codecov-commenter
Copy link

Codecov Report

Merging #1955 (39b640f) into dev (da2608a) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev    #1955      +/-   ##
==========================================
+ Coverage   87.75%   87.78%   +0.02%     
==========================================
  Files         250      250              
  Lines        9542     9542              
==========================================
+ Hits         8374     8376       +2     
+ Misses       1168     1166       -2     
Impacted Files Coverage Δ
...oRaWan.NetworkServer/ManagedConnectionException.cs 25.00% <0.00%> (+25.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Mandur Mandur added the 1️⃣ Priority 1 (One) label Nov 1, 2022
@Mandur Mandur temporarily deployed to CI November 1, 2022 10:12 Inactive
@Mandur Mandur temporarily deployed to CI November 1, 2022 10:12 Inactive
@Mandur Mandur temporarily deployed to CI November 1, 2022 10:13 Inactive
@Mandur Mandur temporarily deployed to CI November 1, 2022 10:13 Inactive
@Mandur Mandur temporarily deployed to CI November 1, 2022 10:13 Inactive
@Mandur Mandur temporarily deployed to CI November 1, 2022 10:13 Inactive
@Mandur Mandur temporarily deployed to CI November 1, 2022 10:13 Inactive
@Mandur Mandur temporarily deployed to CI November 1, 2022 10:15 Inactive
@Mandur Mandur temporarily deployed to CI November 1, 2022 10:15 Inactive
@Mandur Mandur temporarily deployed to CI November 1, 2022 10:15 Inactive
@Mandur Mandur temporarily deployed to CI November 1, 2022 10:15 Inactive
@github-actions github-actions bot added SensorDecodingTest Indicate SensorDecodingTest passed OTAAJoinTest Indicate OTAAJoinTest passed ABPTest Indicate ABPTest passed OTAATest Indicate OTAATest passed MacTest Indicate MacTest passed C2DMessageTest Indicate C2DMessageTest passed labels Nov 1, 2022
@Mandur Mandur temporarily deployed to CI November 1, 2022 13:55 Inactive
@Mandur Mandur temporarily deployed to CI November 1, 2022 13:57 Inactive
@Mandur Mandur temporarily deployed to CI November 1, 2022 13:57 Inactive
@Mandur Mandur temporarily deployed to CI November 1, 2022 13:57 Inactive
@Mandur Mandur temporarily deployed to CI November 1, 2022 13:57 Inactive
@Mandur Mandur temporarily deployed to CI November 1, 2022 14:41 Inactive
@Mandur Mandur force-pushed the feature/fix-logging branch from 126eb35 to d945d43 Compare November 1, 2022 14:44
@Mandur Mandur temporarily deployed to CI November 1, 2022 14:44 Inactive
@Mandur Mandur added the 3️⃣ three label Nov 1, 2022
@Mandur Mandur temporarily deployed to CI November 1, 2022 14:48 Inactive
@Mandur Mandur temporarily deployed to CI November 1, 2022 14:48 Inactive
@Mandur Mandur temporarily deployed to CI November 1, 2022 14:48 Inactive
@Mandur Mandur temporarily deployed to CI November 1, 2022 14:48 Inactive
@Mandur Mandur temporarily deployed to CI November 1, 2022 14:48 Inactive
@Mandur Mandur temporarily deployed to CI November 1, 2022 14:50 Inactive
@Mandur Mandur temporarily deployed to CI November 1, 2022 14:50 Inactive
@Mandur Mandur temporarily deployed to CI November 1, 2022 14:50 Inactive
@Mandur Mandur temporarily deployed to CI November 1, 2022 14:50 Inactive
@Mandur Mandur temporarily deployed to CI November 1, 2022 14:52 Inactive
@Mandur Mandur temporarily deployed to CI November 1, 2022 15:12 Inactive
@github-actions github-actions bot added the ABPTest Indicate ABPTest passed label Nov 1, 2022
@Mandur Mandur merged commit 49f5c04 into dev Nov 1, 2022
@Mandur Mandur deleted the feature/fix-logging branch November 1, 2022 16:18
ouphi pushed a commit to ouphi/iotedge-lorawan-starterkit that referenced this pull request Nov 2, 2022
* Change the path

* Update notice file location

* Remove unused notice import

* remove httpclientfactory logs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1️⃣ Priority 1 (One) 2️⃣ Priority 2 (Two) 3️⃣ three ABPTest Indicate ABPTest passed C2DMessageTest Indicate C2DMessageTest passed CloudDeploymentTest CupsTest fullci Run full continuous integration MacTest Indicate MacTest passed MultiConcentratorTest MultiGatewayTest Indicate MultiGatewayTest passed OTAAJoinTest Indicate OTAAJoinTest passed OTAATest Indicate OTAATest passed SensorDecodingTest Indicate SensorDecodingTest passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the Facade auth code from the logs
3 participants