-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release workflow creates pull requests to update versions in files. #1953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ouphi
changed the title
Create pull requests to update versions when running release workflow.
Release workflow creates pull requests to update versions in files.
Oct 31, 2022
ouphi
force-pushed
the
feature/1950-create-prs-in-release-workflow
branch
from
October 31, 2022 16:42
801f2d6
to
0dea172
Compare
Codecov Report
@@ Coverage Diff @@
## dev #1953 +/- ##
=======================================
Coverage 87.75% 87.75%
=======================================
Files 250 250
Lines 9542 9542
=======================================
Hits 8374 8374
Misses 1168 1168 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Mandur
reviewed
Oct 31, 2022
Mandur
approved these changes
Nov 1, 2022
This was referenced Nov 1, 2022
ouphi
added a commit
to ouphi/iotedge-lorawan-starterkit
that referenced
this pull request
Nov 2, 2022
…zure#1953) * Add steps to create PRs to update doc. * Fix env syntax. * Reduce line size. * Fix. * Update default version in bicep before generating ARM file. * Fix. * Match one or more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for issue #1950
What is being addressed
Automated the following release steps:
Make sure the ARM release artefact has the correct default started kit version.
I considered creating a custom action to reduce the code duplication. I didn't implement this solution because of the following overhead:
docs/main
branch. We could consider committing it to this branch, but it would mean maintaining this action twice.How it was tested
It was tested on a fork to avoid creating PR on this repository.
You can find here a successful run.
You can find here the release created by the run.
You can see the following 2 PRs have been created by the workflow: