Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release workflow creates pull requests to update versions in files. #1953

Merged
merged 8 commits into from
Nov 1, 2022

Conversation

ouphi
Copy link
Collaborator

@ouphi ouphi commented Oct 31, 2022

PR for issue #1950

What is being addressed

  • Automated the following release steps:

    • Create a PR updating the URL button version in the doc, on the target branch docs/main.
    • Create a PR updating the default starter kit version in bicep, on the target branch dev
  • Make sure the ARM release artefact has the correct default started kit version.

I considered creating a custom action to reduce the code duplication. I didn't implement this solution because of the following overhead:

  • State: The custom action would depend on a state: the current checked out branch. This can be confusing IMO.
  • A custom action can only be used it the action file is present in the branch. The custom action is not present in the docs/main branch. We could consider committing it to this branch, but it would mean maintaining this action twice.

How it was tested

It was tested on a fork to avoid creating PR on this repository.
You can find here a successful run.
You can find here the release created by the run.

You can see the following 2 PRs have been created by the workflow:

@ouphi ouphi temporarily deployed to CI October 31, 2022 15:54 Inactive
@ouphi ouphi changed the title Create pull requests to update versions when running release workflow. Release workflow creates pull requests to update versions in files. Oct 31, 2022
@ouphi ouphi temporarily deployed to CI October 31, 2022 16:07 Inactive
@ouphi ouphi temporarily deployed to CI October 31, 2022 16:15 Inactive
@ouphi ouphi force-pushed the feature/1950-create-prs-in-release-workflow branch from 801f2d6 to 0dea172 Compare October 31, 2022 16:42
@ouphi ouphi temporarily deployed to CI October 31, 2022 16:42 Inactive
@ouphi ouphi temporarily deployed to CI October 31, 2022 16:49 Inactive
@ouphi ouphi temporarily deployed to CI October 31, 2022 17:00 Inactive
@codecov-commenter
Copy link

Codecov Report

Merging #1953 (0607018) into dev (70a0a56) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #1953   +/-   ##
=======================================
  Coverage   87.75%   87.75%           
=======================================
  Files         250      250           
  Lines        9542     9542           
=======================================
  Hits         8374     8374           
  Misses       1168     1168           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ouphi ouphi marked this pull request as ready for review October 31, 2022 17:07
@ouphi ouphi merged commit da2608a into dev Nov 1, 2022
@ouphi ouphi deleted the feature/1950-create-prs-in-release-workflow branch November 1, 2022 08:52
ouphi added a commit to ouphi/iotedge-lorawan-starterkit that referenced this pull request Nov 2, 2022
…zure#1953)

* Add steps to create PRs to update doc.

* Fix env syntax.

* Reduce line size.

* Fix.

* Update default version in bicep before generating ARM file.

* Fix.

* Match one or more.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants