Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading naming used in documentation and code about certain certificates #5937

Closed
vjrantal opened this issue Dec 17, 2021 · 1 comment · Fixed by #5998
Closed

Misleading naming used in documentation and code about certain certificates #5937

vjrantal opened this issue Dec 17, 2021 · 1 comment · Fixed by #5998
Assignees
Labels

Comments

@vjrantal
Copy link
Contributor

Expected Behavior

It would be good if documentation and code is aligned on the terminology used to describe various types of certificates.

Current Behavior

In here, it is said that workload CA certificate was deprecated.

When using IoT Edge with default settings, the common name of the certificate that the Edge Hub use is iotedged workload ca (coming from this line). The naming sounds misaligned with the deprecation note in the documentation.

@arsing
Copy link
Member

arsing commented Dec 27, 2021

Yeah, I'd noticed that when the code had originally been merged but we kept putting off fixing it.

@arsing arsing added the bug Something isn't working label Dec 27, 2021
@arsing arsing self-assigned this Dec 28, 2021
@pmzara pmzara added the docs label Jan 10, 2022
@kodiakhq kodiakhq bot closed this as completed in #5998 Jan 14, 2022
kodiakhq bot pushed a commit that referenced this issue Jan 14, 2022
This affects the certd config generated by running `iotedge config apply`,
as well as a new Edge CA cert issued when the current one expires *and*
the common name has not been set explicitly in certd config already.

Fixes #5937
Ref #4740

Also fix iotedge-check tests to not require sudo access.

Ref #5927 (comment)
lt72 pushed a commit to lt72/iotedge that referenced this issue Jan 31, 2022
…5998)

This affects the certd config generated by running `iotedge config apply`,
as well as a new Edge CA cert issued when the current one expires *and*
the common name has not been set explicitly in certd config already.

Fixes Azure#5937
Ref Azure#4740

Also fix iotedge-check tests to not require sudo access.

Ref Azure#5927 (comment)
damonbarry added a commit to damonbarry/iotedge that referenced this issue Apr 15, 2022
…5998)

This affects the certd config generated by running `iotedge config apply`,
as well as a new Edge CA cert issued when the current one expires *and*
the common name has not been set explicitly in certd config already.

Fixes Azure#5937
Ref Azure#4740

Also fix iotedge-check tests to not require sudo access.

Ref Azure#5927 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants