GetModuleLogs works with http endpoints #3908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damonbarry
approved these changes
Nov 16, 2020
|
Fixes #3795. |
lfitchett
added a commit
to lfitchett/iotedge
that referenced
this pull request
Nov 18, 2020
This was a simple fix. ~~The new e2e tests currently do not test the http configuration for mgmt and workload sockets, so there may be a follow up to add tests.~~ Since http is not officially supported for mgmt and workload sockets, no tests will be added.
kodiakhq bot
pushed a commit
that referenced
this pull request
Nov 30, 2020
This was a simple fix. ~~The new e2e tests currently do not test the http configuration for mgmt and workload sockets, so there may be a follow up to add tests.~~ Since http is not officially supported for mgmt and workload sockets, no tests will be added.
yophilav
pushed a commit
to yophilav/iotedge
that referenced
this pull request
Dec 17, 2020
This was a simple fix. ~~The new e2e tests currently do not test the http configuration for mgmt and workload sockets, so there may be a follow up to add tests.~~ Since http is not officially supported for mgmt and workload sockets, no tests will be added.
yophilav
pushed a commit
to yophilav/iotedge
that referenced
this pull request
Dec 17, 2020
This was a simple fix. ~~The new e2e tests currently do not test the http configuration for mgmt and workload sockets, so there may be a follow up to add tests.~~ Since http is not officially supported for mgmt and workload sockets, no tests will be added.
gordonwang0
pushed a commit
to gordonwang0/iotedge
that referenced
this pull request
Jan 12, 2021
This was a simple fix. ~~The new e2e tests currently do not test the http configuration for mgmt and workload sockets, so there may be a follow up to add tests.~~ Since http is not officially supported for mgmt and workload sockets, no tests will be added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a simple fix.
The new e2e tests currently do not test the http configuration for mgmt and workload sockets, so there may be a follow up to add tests.Since http is not officially supported for mgmt and workload sockets, no tests will be added.