-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix 8419918]: fixed message counts metrics #3980
Merged
davilu
merged 14 commits into
Azure:master
from
davilu:davilu/metrics-fix-message-counts
Nov 19, 2020
Merged
[Fix 8419918]: fixed message counts metrics #3980
davilu
merged 14 commits into
Azure:master
from
davilu:davilu/metrics-fix-message-counts
Nov 19, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davilu
requested review from
varunpuranik,
dylanbronson,
ancaantochi and
richma-ms
November 17, 2020 02:49
/azp run |
Azure Pipelines successfully started running 6 pipeline(s). |
edge-hub/core/src/Microsoft.Azure.Devices.Edge.Hub.Core/storage/MessageStore.cs
Outdated
Show resolved
Hide resolved
edge-hub/core/src/Microsoft.Azure.Devices.Edge.Hub.Core/storage/MessageStore.cs
Outdated
Show resolved
Hide resolved
edge-hub/core/test/Microsoft.Azure.Devices.Edge.Hub.Core.Test/DeviceMessageHandlerTest.cs
Show resolved
Hide resolved
edge-hub/core/test/Microsoft.Azure.Devices.Routing.Core.Test/MessageQueueIdHelperTest.cs
Outdated
Show resolved
Hide resolved
edge-hub/core/src/Microsoft.Azure.Devices.Routing.Core/MessageQueueIdHelper.cs
Outdated
Show resolved
Hide resolved
edge-hub/core/test/Microsoft.Azure.Devices.Edge.Hub.Core.Test/DeviceMessageHandlerTest.cs
Show resolved
Hide resolved
edge-hub/core/test/Microsoft.Azure.Devices.Routing.Core.Test/MessageQueueIdHelperTest.cs
Show resolved
Hide resolved
edge-hub/core/src/Microsoft.Azure.Devices.Edge.Hub.Core/storage/MessageStore.cs
Show resolved
Hide resolved
…m/davilu/iotedge into davilu/metrics-fix-message-counts
richma-ms
reviewed
Nov 18, 2020
edge-hub/core/src/Microsoft.Azure.Devices.Edge.Hub.Core/storage/MessageStore.cs
Show resolved
Hide resolved
/azp run |
Azure Pipelines successfully started running 6 pipeline(s). |
richma-ms
approved these changes
Nov 19, 2020
davilu
added a commit
to davilu/iotedge
that referenced
this pull request
Nov 25, 2020
* fixed message count metrics
davilu
added a commit
that referenced
this pull request
Dec 1, 2020
* [Fix 8419918]: fixed message counts metrics (#3980) * fixed message count metrics * Fix cleanup processor (#4020) * Changing name and adding attribute * adding bool.trueString to cleanup processor metrics label to fix it Co-authored-by: davilu <45977130+davilu@users.noreply.github.com> Co-authored-by: dylanbronson <55515325+dylanbronson@users.noreply.github.com>
gordonwang0
pushed a commit
to gordonwang0/iotedge
that referenced
this pull request
Jan 12, 2021
* fixed message count metrics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified to update message counts metrics after clean up