Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick to 1.0.10: Fix InMemoryDbStoreLimitsTest (#4048) #4056

Merged
merged 1 commit into from
Dec 7, 2020
Merged

Cherry-pick to 1.0.10: Fix InMemoryDbStoreLimitsTest (#4048) #4056

merged 1 commit into from
Dec 7, 2020

Commits on Dec 7, 2020

  1. Fix InMemoryDbStoreLimitsTest (Azure#4048) 

    InMemoryDbStoreLimitsTest is flaky in the CI pipeline. I believe it is because we overuse the "sender1" name. The test keeps failing on "Amqp resource is disconnected," which I think we get because we're trying to access an AMQP resource that has previously closed. This would make sense if we are using the "sender1" name somewhere else around the same time.

So this pr just changes the name to be more specific to the test. I've run it ~8 times in the pipeline and haven't seen the failure, so it looks like it solves the problem.
    @dylanbronson
    dylanbronson committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    19fc93d View commit details
    Browse the repository at this point in the history