[8403008] Add client connection related edgeHub metrics #4060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ice connect/disconnected to/from iot edge
davilu
requested review from
ancaantochi,
richma-ms,
varunpuranik and
veyalla
veyalla
reviewed
Dec 8, 2020
edge-hub/src/Microsoft.Azure.Devices.Edge.Hub.Core/DeviceConnectionMetrics.cs
Outdated
Show resolved
Hide resolved
veyalla
reviewed
Dec 8, 2020
edge-hub/src/Microsoft.Azure.Devices.Edge.Hub.Core/DeviceConnectionMetrics.cs
Outdated
Show resolved
Hide resolved
veyalla
reviewed
Dec 8, 2020
edge-hub/src/Microsoft.Azure.Devices.Edge.Hub.Core/DeviceConnectionMetrics.cs
Outdated
Show resolved
Hide resolved
veyalla
reviewed
Dec 8, 2020
…ctionMetrics.cs Co-authored-by: Venkat Yalla <veyalla@microsoft.com>
…ctionMetrics.cs Co-authored-by: Venkat Yalla <veyalla@microsoft.com>
…ctionMetrics.cs Co-authored-by: Venkat Yalla <veyalla@microsoft.com>
Co-authored-by: Venkat Yalla <veyalla@microsoft.com>
veyalla
reviewed
Dec 8, 2020
veyalla
reviewed
Dec 8, 2020
Co-authored-by: Venkat Yalla <veyalla@microsoft.com>
Co-authored-by: Venkat Yalla <veyalla@microsoft.com>
veyalla
reviewed
Dec 8, 2020
Co-authored-by: Venkat Yalla <veyalla@microsoft.com>
yophilav
reviewed
Dec 9, 2020
edge-hub/src/Microsoft.Azure.Devices.Edge.Hub.Core/DeviceConnectionMetrics.cs
Outdated
Show resolved
Hide resolved
…added ignore disconnect in e2e test
yophilav
pushed a commit
to yophilav/iotedge
that referenced
this pull request
Dec 17, 2020
* added metrics for current number of connected clients, individual device connect/disconnected to/from iot edge * updated doc/BuiltInMetrics.md * modified failed connection metrics description to align with doc and added ignore disconnect in e2e test
yophilav
pushed a commit
to yophilav/iotedge
that referenced
this pull request
Dec 17, 2020
* added metrics for current number of connected clients, individual device connect/disconnected to/from iot edge * updated doc/BuiltInMetrics.md * modified failed connection metrics description to align with doc and added ignore disconnect in e2e test
davilu
added a commit
to davilu/iotedge
that referenced
this pull request
Dec 18, 2020
* added metrics for current number of connected clients, individual device connect/disconnected to/from iot edge * updated doc/BuiltInMetrics.md * modified failed connection metrics description to align with doc and added ignore disconnect in e2e test
davilu
added a commit
to davilu/iotedge
that referenced
this pull request
Dec 18, 2020
* added metrics for current number of connected clients, individual device connect/disconnected to/from iot edge * updated doc/BuiltInMetrics.md * modified failed connection metrics description to align with doc and added ignore disconnect in e2e test
davilu
added a commit
that referenced
this pull request
Dec 18, 2020
) * [8403008] Add client connection related edgeHub metrics (#4060) * added metrics for current number of connected clients, individual device connect/disconnected to/from iot edge * updated doc/BuiltInMetrics.md * modified failed connection metrics description to align with doc and added ignore disconnect in e2e test * [8982026] fix metrics e2e test (#4125) * added metrics for current number of connected clients, individual device connect/disconnected to/from iot edge * fixed metrics description * fixed UT ConnectionManagerTest by adding missing mock which impacted by metrics change * Update edge-hub/src/Microsoft.Azure.Devices.Edge.Hub.Core/DeviceConnectionMetrics.cs Co-authored-by: Venkat Yalla <veyalla@microsoft.com> * Update edge-hub/src/Microsoft.Azure.Devices.Edge.Hub.Core/DeviceConnectionMetrics.cs Co-authored-by: Venkat Yalla <veyalla@microsoft.com> * Update edge-hub/src/Microsoft.Azure.Devices.Edge.Hub.Core/DeviceConnectionMetrics.cs Co-authored-by: Venkat Yalla <veyalla@microsoft.com> * Update doc/BuiltInMetrics.md Co-authored-by: Venkat Yalla <veyalla@microsoft.com> * Update doc/BuiltInMetrics.md Co-authored-by: Venkat Yalla <veyalla@microsoft.com> * Update doc/BuiltInMetrics.md Co-authored-by: Venkat Yalla <veyalla@microsoft.com> * Update doc/BuiltInMetrics.md Co-authored-by: Venkat Yalla <veyalla@microsoft.com> * modified to use Array.Empty * modified failed connection metrics description to align with doc and added ignore disconnect in e2e test * fixed typo in md file Co-authored-by: Venkat Yalla <veyalla@microsoft.com> * moved new cs file to modified location Co-authored-by: Venkat Yalla <veyalla@microsoft.com>
davilu
added a commit
that referenced
this pull request
Dec 18, 2020
…#4134) * [8403008] Add client connection related edgeHub metrics (#4060) * added metrics for current number of connected clients, individual device connect/disconnected to/from iot edge * updated doc/BuiltInMetrics.md * modified failed connection metrics description to align with doc and added ignore disconnect in e2e test * [8982026] fix metrics e2e test (#4125) * added metrics for current number of connected clients, individual device connect/disconnected to/from iot edge * fixed metrics description * fixed UT ConnectionManagerTest by adding missing mock which impacted by metrics change * Update edge-hub/src/Microsoft.Azure.Devices.Edge.Hub.Core/DeviceConnectionMetrics.cs Co-authored-by: Venkat Yalla <veyalla@microsoft.com> * Update edge-hub/src/Microsoft.Azure.Devices.Edge.Hub.Core/DeviceConnectionMetrics.cs Co-authored-by: Venkat Yalla <veyalla@microsoft.com> * Update edge-hub/src/Microsoft.Azure.Devices.Edge.Hub.Core/DeviceConnectionMetrics.cs Co-authored-by: Venkat Yalla <veyalla@microsoft.com> * Update doc/BuiltInMetrics.md Co-authored-by: Venkat Yalla <veyalla@microsoft.com> * Update doc/BuiltInMetrics.md Co-authored-by: Venkat Yalla <veyalla@microsoft.com> * Update doc/BuiltInMetrics.md Co-authored-by: Venkat Yalla <veyalla@microsoft.com> * Update doc/BuiltInMetrics.md Co-authored-by: Venkat Yalla <veyalla@microsoft.com> * modified to use Array.Empty * modified failed connection metrics description to align with doc and added ignore disconnect in e2e test * fixed typo in md file Co-authored-by: Venkat Yalla <veyalla@microsoft.com> * moved new cs file to modified location Co-authored-by: Venkat Yalla <veyalla@microsoft.com>
gordonwang0
pushed a commit
to gordonwang0/iotedge
that referenced
this pull request
Jan 5, 2021
…ure#4132) * [8403008] Add client connection related edgeHub metrics (Azure#4060) * added metrics for current number of connected clients, individual device connect/disconnected to/from iot edge * updated doc/BuiltInMetrics.md * modified failed connection metrics description to align with doc and added ignore disconnect in e2e test * [8982026] fix metrics e2e test (Azure#4125) * added metrics for current number of connected clients, individual device connect/disconnected to/from iot edge * fixed metrics description * fixed UT ConnectionManagerTest by adding missing mock which impacted by metrics change * Update edge-hub/src/Microsoft.Azure.Devices.Edge.Hub.Core/DeviceConnectionMetrics.cs Co-authored-by: Venkat Yalla <veyalla@microsoft.com> * Update edge-hub/src/Microsoft.Azure.Devices.Edge.Hub.Core/DeviceConnectionMetrics.cs Co-authored-by: Venkat Yalla <veyalla@microsoft.com> * Update edge-hub/src/Microsoft.Azure.Devices.Edge.Hub.Core/DeviceConnectionMetrics.cs Co-authored-by: Venkat Yalla <veyalla@microsoft.com> * Update doc/BuiltInMetrics.md Co-authored-by: Venkat Yalla <veyalla@microsoft.com> * Update doc/BuiltInMetrics.md Co-authored-by: Venkat Yalla <veyalla@microsoft.com> * Update doc/BuiltInMetrics.md Co-authored-by: Venkat Yalla <veyalla@microsoft.com> * Update doc/BuiltInMetrics.md Co-authored-by: Venkat Yalla <veyalla@microsoft.com> * modified to use Array.Empty * modified failed connection metrics description to align with doc and added ignore disconnect in e2e test * fixed typo in md file Co-authored-by: Venkat Yalla <veyalla@microsoft.com> * moved new cs file to modified location Co-authored-by: Venkat Yalla <veyalla@microsoft.com>
gordonwang0
pushed a commit
to gordonwang0/iotedge
that referenced
this pull request
Jan 12, 2021
…ure#4132) * [8403008] Add client connection related edgeHub metrics (Azure#4060) * added metrics for current number of connected clients, individual device connect/disconnected to/from iot edge * updated doc/BuiltInMetrics.md * modified failed connection metrics description to align with doc and added ignore disconnect in e2e test * [8982026] fix metrics e2e test (Azure#4125) * added metrics for current number of connected clients, individual device connect/disconnected to/from iot edge * fixed metrics description * fixed UT ConnectionManagerTest by adding missing mock which impacted by metrics change * Update edge-hub/src/Microsoft.Azure.Devices.Edge.Hub.Core/DeviceConnectionMetrics.cs Co-authored-by: Venkat Yalla <veyalla@microsoft.com> * Update edge-hub/src/Microsoft.Azure.Devices.Edge.Hub.Core/DeviceConnectionMetrics.cs Co-authored-by: Venkat Yalla <veyalla@microsoft.com> * Update edge-hub/src/Microsoft.Azure.Devices.Edge.Hub.Core/DeviceConnectionMetrics.cs Co-authored-by: Venkat Yalla <veyalla@microsoft.com> * Update doc/BuiltInMetrics.md Co-authored-by: Venkat Yalla <veyalla@microsoft.com> * Update doc/BuiltInMetrics.md Co-authored-by: Venkat Yalla <veyalla@microsoft.com> * Update doc/BuiltInMetrics.md Co-authored-by: Venkat Yalla <veyalla@microsoft.com> * Update doc/BuiltInMetrics.md Co-authored-by: Venkat Yalla <veyalla@microsoft.com> * modified to use Array.Empty * modified failed connection metrics description to align with doc and added ignore disconnect in e2e test * fixed typo in md file Co-authored-by: Venkat Yalla <veyalla@microsoft.com> * moved new cs file to modified location Co-authored-by: Venkat Yalla <veyalla@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
edgehub_connected_clients: current number of connected clients to edge hubedgehub_client_connect_success_total: total number of times individual client successfully connect to edgeHubedgehub_client_disconnect_total: total number of times individual client disconnected from edgeHubedgehub_client_connect_failed_totalreport failure while re-auth failed