Add runtime to create options #4080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ancaantochi
force-pushed
the
ancan/fix-create-options
branch
from
6348c97
to
0139e2e
Compare
darobs
suggested changes
Dec 16, 2020
edge-agent/src/Microsoft.Azure.Devices.Edge.Agent.Docker/models/HostConfig.cs
Show resolved
Hide resolved
ancaantochi
added a commit
to ancaantochi/iotedge
that referenced
this pull request
Dec 18, 2020
* Add HostConfig properties
ancaantochi
added a commit
to ancaantochi/iotedge
that referenced
this pull request
Dec 18, 2020
* Add HostConfig properties
ancaantochi
added a commit
to ancaantochi/iotedge
that referenced
this pull request
Dec 18, 2020
* Add HostConfig properties
gordonwang0
pushed a commit
to gordonwang0/iotedge
that referenced
this pull request
Jan 5, 2021
* Add HostConfig properties
gordonwang0
pushed a commit
to gordonwang0/iotedge
that referenced
this pull request
Jan 12, 2021
* Add HostConfig properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HostConfig properties used to be serialized/deserialized using Docker.DotNet.Models.HostConfig class which was missing some of the properties that where added to docker since HostConfig class was last update. In order to support all current properties and also future properties, HostConfig class was added to the project with a few properties that are directly used in code and all others were set in the OtherProperties with JsonExtendedData attribute to deserialize properties with no matching class member into the dictionary.
Having properties in the dictionary is causing issues when using iotedged version 1.0.9 and edgeAgent 1.0.10 and if the property is all lowercase, because iotedged will ignore it. To fix the issue I added all properties that HostConfig had in 1.0.9.