-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Rust Coverage #5616
Merged
kodiakhq
merged 30 commits into
Azure:master
from
nimanch:personal/nimanch/enablerustcoverage
Oct 7, 2021
Merged
Enable Rust Coverage #5616
kodiakhq
merged 30 commits into
Azure:master
from
nimanch:personal/nimanch/enablerustcoverage
Oct 7, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…com/nimanch/iotedge into personal/nimanch/enablerustcoverage
@varunpuranik Does anyone from your team want/need to review this? |
varunpuranik
requested review from
arsing,
dmolokanov,
vadim-kovalyov and
onalante-msft
October 6, 2021 20:01
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does anyone remember why this has been disabled in the first place?
Also, there are a lot of "untestable" or hardly testable code in the edgelet, so excluded files needs to be updated. Probably in the following PRs.
arsing
reviewed
Oct 6, 2021
arsing
approved these changes
Oct 7, 2021
nimanch
added a commit
to nimanch/iotedge
that referenced
this pull request
Oct 7, 2021
This PR Re-enables Rust Coverage in Check in Pipelines 1. Remove the Dependency to on nightly build on Rust. Use the same version of rust as other pipelines 2. Use Cargo Tarpaulin for Create Code Coverage Reports. This was recommended by other teams within Microsoft developing rust code. (https://lib.rs/crates/cargo-tarpaulin) 3. Publish HTML Code Coverage Report Based on Coverage Report Note : The Current Code Coverage stands at 44%. I had to reduce the code coverage gate for Rust to 44%. The intent is to increase the code coverage and then increase the gate. Sample Build : https://iotedge.visualstudio.com/iotedge/_build/results?buildId=83180&view=codecoverage-tab
damonbarry
pushed a commit
to damonbarry/iotedge
that referenced
this pull request
Apr 15, 2022
This PR Re-enables Rust Coverage in Check in Pipelines 1. Remove the Dependency to on nightly build on Rust. Use the same version of rust as other pipelines 2. Use Cargo Tarpaulin for Create Code Coverage Reports. This was recommended by other teams within Microsoft developing rust code. (https://lib.rs/crates/cargo-tarpaulin) 3. Publish HTML Code Coverage Report Based on Coverage Report Note : The Current Code Coverage stands at 44%. I had to reduce the code coverage gate for Rust to 44%. The intent is to increase the code coverage and then increase the gate. Sample Build : https://iotedge.visualstudio.com/iotedge/_build/results?buildId=83180&view=codecoverage-tab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Re-enables Rust Coverage in Check in Pipelines
Note : The Current Code Coverage stands at 44%. I had to reduce the code coverage gate for Rust to 44%. The intent is to increase the code coverage and then increase the gate.
Sample Build : https://iotedge.visualstudio.com/iotedge/_build/results?buildId=83180&view=codecoverage-tab