Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Rust Coverage #5616

Merged
merged 30 commits into from
Oct 7, 2021

Conversation

nimanch
Copy link
Contributor

@nimanch nimanch commented Oct 4, 2021

This PR Re-enables Rust Coverage in Check in Pipelines

  1. Remove the Dependency to on nightly build on Rust. Use the same version of rust as other pipelines
  2. Use Cargo Tarpaulin for Create Code Coverage Reports. This was recommended by other teams within Microsoft developing rust code. (https://lib.rs/crates/cargo-tarpaulin)
  3. Publish HTML Code Coverage Report Based on Coverage Report

Note : The Current Code Coverage stands at 44%. I had to reduce the code coverage gate for Rust to 44%. The intent is to increase the code coverage and then increase the gate.

Sample Build : https://iotedge.visualstudio.com/iotedge/_build/results?buildId=83180&view=codecoverage-tab

@nimanch nimanch marked this pull request as ready for review October 6, 2021 01:18
@nimanch nimanch requested a review from scb01 October 6, 2021 18:39
@damonbarry
Copy link
Member

@varunpuranik Does anyone from your team want/need to review this?

Copy link
Contributor

@vadim-kovalyov vadim-kovalyov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does anyone remember why this has been disabled in the first place?

Also, there are a lot of "untestable" or hardly testable code in the edgelet, so excluded files needs to be updated. Probably in the following PRs.

builds/checkin/edgelet.yaml Show resolved Hide resolved
builds/checkin/edgelet.yaml Outdated Show resolved Hide resolved
builds/checkin/edgelet.yaml Outdated Show resolved Hide resolved
@kodiakhq kodiakhq bot merged commit 1c672b5 into Azure:master Oct 7, 2021
nimanch added a commit to nimanch/iotedge that referenced this pull request Oct 7, 2021
This PR Re-enables Rust Coverage in Check in Pipelines
1. Remove the Dependency to on nightly build on Rust. Use the same version of rust as other pipelines
2. Use Cargo Tarpaulin for Create Code Coverage Reports. This was recommended by other teams within Microsoft developing rust code. (https://lib.rs/crates/cargo-tarpaulin)
3. Publish HTML Code Coverage Report Based on Coverage Report


Note : The Current Code Coverage stands at 44%.  I had to reduce the code coverage gate for Rust to 44%.  The intent is to increase the code coverage and then increase the gate.

Sample Build : https://iotedge.visualstudio.com/iotedge/_build/results?buildId=83180&view=codecoverage-tab
damonbarry pushed a commit to damonbarry/iotedge that referenced this pull request Apr 15, 2022
This PR Re-enables Rust Coverage in Check in Pipelines
1. Remove the Dependency to on nightly build on Rust. Use the same version of rust as other pipelines
2. Use Cargo Tarpaulin for Create Code Coverage Reports. This was recommended by other teams within Microsoft developing rust code. (https://lib.rs/crates/cargo-tarpaulin)
3. Publish HTML Code Coverage Report Based on Coverage Report


Note : The Current Code Coverage stands at 44%.  I had to reduce the code coverage gate for Rust to 44%.  The intent is to increase the code coverage and then increase the gate.

Sample Build : https://iotedge.visualstudio.com/iotedge/_build/results?buildId=83180&view=codecoverage-tab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants